Re: [devel] [PATCH 1/1] clmd: not send sync respond to client if node down [#3004]

2019-02-12 Thread Thang Nguyen
Hi Minh, There is NO node info in data base of CLM in both case node down and node unconfigured. So we can not use it to distingush b/w them. B.R /Thang -Original Message- From: Minh Hon Chau Sent: Wednesday, February 13, 2019 9:49 AM To: Tran Thuan ; 'thang.d.nguyen' ;

Re: [devel] [PATCH 1/1] clmd: not send sync respond to client if node down [#3004]

2019-02-12 Thread Minh Hon Chau
Hi Thang, The patch looks ok, but I'm thinking of not introducing mds_node_down_list. In SAI-AIS-CLM-B.04.01: "The term unconfigured node is used in this document to designate an execution environment that is not configured to host a CLM node." May we add a check if a node is unconfigured

Re: [devel] [PATCH 1/1] clmd: not send sync respond to client if node down [#3004]

2019-01-31 Thread Tran Thuan
Hi Thang, ACK from me for code review, not tested. Best Regards, ThuanTr -Original Message- From: thang.d.nguyen Sent: Wednesday, January 30, 2019 1:20 AM To: gary@dektech.com.au; minh.c...@dektech.com.au; thuan.t...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net;

[devel] [PATCH 1/1] clmd: not send sync respond to client if node down [#3004]

2019-01-31 Thread thang.d.nguyen
Clmd will not send sync respond to client if the node that client resided on down. This will avoid timeout when clmd send via mds. --- src/clm/clmd/clms_cb.h | 3 +++ src/clm/clmd/clms_evt.cc | 22 +- src/clm/clmd/clms_mds.cc | 2 +- 3 files changed, 21 insertions(+), 6

Re: [devel] [PATCH 1/1] clmd: not send sync respond to client if node down [#3004]

2019-01-31 Thread Thang Nguyen
Hi Thuan, See my comment in line. Due to use mutext lock can cause the mds thread stuck or process lower. So I update the solution to NOT use the mutex. Instead of change the node down priority of MDS node down event >From HIGH to VERY_HIGH plus add the set to record the nod_id when receives MDS

Re: [devel] [PATCH 1/1] clmd: not send sync respond to client if node down [#3004]

2019-01-29 Thread Tran Thuan
Hi Thang, Some comments inline with [Thuan] Best Regards, ThuanTr -Original Message- From: thang.d.nguyen Sent: Tuesday, January 29, 2019 4:53 AM To: gary@dektech.com.au; minh.c...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net Subject: [devel] [PATCH 1/1] clmd: not send

[devel] [PATCH 1/1] clmd: not send sync respond to client if node down [#3004]

2019-01-29 Thread thang.d.nguyen
clmd will not send sync respond to client if the node that client resided on down. This will avoid timeout when clmd send via mds. --- src/clm/clmd/clms_cb.h| 5 src/clm/clmd/clms_evt.cc | 35 ++- src/clm/clmd/clms_evt.h | 1 + src/clm/clmd/clms_main.cc | 4