[devel] [PATCH 1/1] dtm: Fix dtm close socket due to duplication of adding node IP info [#2984]

2019-03-07 Thread Canh Van Truong
During cluster start, one node (node 1) broadcast up msg to other node. The remote node (node 2) get this msg and send the connection to node 1 (connect()). Similarly node 1 send the connection to node 2 after node 2 broadcast up msg to. Beside of node 2 connect() to node 1, node 2 also add the

Re: [devel] [PATCH 1/1] dtm: Fix dtm close socket due to duplication of adding node IP info [#2984]

2019-03-06 Thread Canh Van Truong
Hi Gary and Hans, Thanks for your review. I updated Gary comment and running patch test again. @Hans. Because there is just small changes that does not related to the ticket. (the changes in dtm_node_delete() and dtm_node_add() with replace number by enum) so I don’t separate the patch. I

Re: [devel] [PATCH 1/1] dtm: Fix dtm close socket due to duplication of adding node IP info [#2984]

2019-03-06 Thread Gary Lee
Hi Canh One minor comment, KEY_TYPES should probably be called KeyTypes. Also, can you make it an enum class, rather than plain enum? Thanks Gary On 7/3/19 12:53 am, Hans Nordebäck wrote: Hi Canh, ack, review only. I think it would be good to separate the re-factoring part in a separate

Re: [devel] [PATCH 1/1] dtm: Fix dtm close socket due to duplication of adding node IP info [#2984]

2019-03-06 Thread Hans Nordebäck
Hi Canh, ack, review only. I think it would be good to separate the re-factoring part in a separate ticket though. /BR Hans On 12/18/18 08:25, Canh Van Truong wrote: > During cluster start, one node (node 1) broadcast up msg to other node. The > remote node (node 2) get this msg and send the

[devel] [PATCH 1/1] dtm: Fix dtm close socket due to duplication of adding node IP info [#2984]

2018-12-17 Thread Canh Van Truong
During cluster start, one node (node 1) broadcast up msg to other node. The remote node (node 2) get this msg and send the connection to node 1 (connect()). Similarly node 1 send the connection to node 2 after node 2 broadcast up msg to. Beside of node 2 connect() to node 1, node 2 also add the

[devel] [PATCH 1/1] dtm: Fix dtm close socket due to duplication of adding node IP info [#2984]

2018-12-17 Thread Canh Van Truong
During cluster start, one node (node 1) broadcast up msg to other node. The remote node (node 2) get this msg and send the connection to node 1 (connect()). Similarly node 1 send the connection to node 2 after node 2 broadcast up msg to. Beside of node 2 connect() to node 1, node 2 also add the