Re: [devel] [PATCH 1/1] imm: make version parameter in immutil_xxx non-const [#2830]

2018-04-16 Thread Ravi Sekhar Reddy Konda
Hi Vu, Ack with a comment, make sure to reset local_version wherever API is called in a loop Thanks, Ravi -Original Message- From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] Sent: Thursday, April 05, 2018 4:09 PM To: ravisekhar.ko...@oracle.com; hans.nordeb...@ericsson.com; an

Re: [devel] [PATCH 1/1] imm: make version parameter in immutil_xxx non-const [#2830]

2018-04-12 Thread Vu Minh Nguyen
Thanks Lennart. I will update the code as your comments before pushing. @Ravi: Any comment from you? Thanks. Regards, Vu > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] > Sent: Thursday, April 12, 2018 8:32 PM > To: Vu Minh Nguyen ; > ravisekhar.ko...@oracle.

Re: [devel] [PATCH 1/1] imm: make version parameter in immutil_xxx non-const [#2830]

2018-04-12 Thread Lennart Lund
> -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 12 april 2018 12:37 > To: Lennart Lund ; > ravisekhar.ko...@oracle.com; Hans Nordebäck > ; Anders Widell > > Cc: opensaf-devel@lists.sourceforge.net > Subject: RE: [PATCH 1/1] imm: make version pa

Re: [devel] [PATCH 1/1] imm: make version parameter in immutil_xxx non-const [#2830]

2018-04-12 Thread Vu Minh Nguyen
Hi Lennart, See my response inline, started with [Vu]. Regards, Vu > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] > Sent: Thursday, April 12, 2018 5:13 PM > To: Vu Minh Nguyen ; > ravisekhar.ko...@oracle.com; Hans Nordebäck > ; Anders Widell > > Cc: opensaf

Re: [devel] [PATCH 1/1] imm: make version parameter in immutil_xxx non-const [#2830]

2018-04-12 Thread Lennart Lund
Hi Vu, Ack, but an important issue to fix. See comments below [Lennart] Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 5 april 2018 12:39 > To: ravisekhar.ko...@oracle.com; Hans Nordebäck > ; Anders Widell > ; Lennart Lund > Cc

Re: [devel] [PATCH 1/1] imm: make version parameter in immutil_xxx non-const [#2830]

2018-04-10 Thread Vu Minh Nguyen
Hi, Do you have any comments on this patch? Thanks. Regards, Vu > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: Thursday, April 5, 2018 5:39 PM > To: ravisekhar.ko...@oracle.com; hans.nordeb...@ericsson.com; > anders.wid...@ericsson.com; lennart.l

[devel] [PATCH 1/1] imm: make version parameter in immutil_xxx non-const [#2830]

2018-04-05 Thread Vu Minh Nguyen
The version in saImmO{m,i}Initialize is input/output parameter and is declared as non-constant for both IMM OM and OI API according to SAF spec. But in immutil wrapper library, some are declared as constant and don't update the in/out version before returning from such wrappers. This patch makes t