Re: [devel] [PATCH 1/1] mds: Do not check upper limit of window size [#3100]

2019-10-16 Thread Tran Thuan
Hi Minh, ACK from me. Best Regards, ThuanTr -Original Message- From: Minh Chau Sent: Wednesday, October 16, 2019 6:53 PM To: thuan.t...@dektech.com.au; hans.nordeb...@ericsson.com; gary@dektech.com.au; vu.m.ngu...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net; Minh Chau S

[devel] [PATCH 1/1] mds: Do not check upper limit of window size [#3100]

2019-10-16 Thread Minh Chau
According to RFC1982: "Addition of a value outside the range [0 .. (2^(SERIAL_BITS - 1) - 1)] is undefined.". Mds uses 16 bits for mds flow control, thus the maximum allowed range of window size is 2^15 - 1 = 32767. The 'mdstest 27 8' has randomly hit this limitation with the counter errors that is