[devel] [PATCH 1/1] mds: fix mds_tipc_fctrl_shutdown() stuck forever [#3169]

2020-03-23 Thread thuan.tran
- Deadlock of portid_map_mutex locking: mds_tipc_fctrl_shutdown() take lock then wait for thread process_all_events() to be canceled. But that thread also want get lock then it is keep waiting for lock. - Create safe method to cancel process_all_events() thread similar as the way MDS destroy legacy

Re: [devel] [PATCH 1/1] mds: fix mds_tipc_fctrl_shutdown() stuck forever [#3169]

2020-03-30 Thread minhchau
Hi Thuan, Please find my comments inline [M] Thanks Minh On 23/3/20 8:59 pm, thuan.tran wrote: - Deadlock of portid_map_mutex locking: mds_tipc_fctrl_shutdown() take lock then wait for thread process_all_events() to be canceled. But that thread also want get lock then it is keep waiting for l

Re: [devel] [PATCH 1/1] mds: fix mds_tipc_fctrl_shutdown() stuck forever [#3169]

2020-03-30 Thread Thuan Tran
Hi Minh, Thanks for reviewing. See my replies inline. Best Regards, ThuanTr -Original Message- From: Minh Hon Chau Sent: Monday, March 30, 2020 5:00 PM To: Thuan Tran ; Thang Duc Nguyen Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1/1] mds: fix mds_tipc_fctrl_shutdown(

Re: [devel] [PATCH 1/1] mds: fix mds_tipc_fctrl_shutdown() stuck forever [#3169]

2020-03-30 Thread minhchau
Hi Thuan, More comments inline. Thanks Minh On 30/3/20 9:19 pm, Thuan Tran wrote: Hi Minh, Thanks for reviewing. See my replies inline. Best Regards, ThuanTr -Original Message- From: Minh Hon Chau Sent: Monday, March 30, 2020 5:00 PM To: Thuan Tran ; Thang Duc Nguyen Cc: opensaf

Re: [devel] [PATCH 1/1] mds: fix mds_tipc_fctrl_shutdown() stuck forever [#3169]

2020-03-30 Thread Thuan Tran
Hi Minh, See my replies inline. Best Regards, ThuanTr -Original Message- From: Minh Hon Chau Sent: Tuesday, March 31, 2020 8:05 AM To: Thuan Tran ; Thang Duc Nguyen Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1/1] mds: fix mds_tipc_fctrl_shutdown() stuck forever [#31

Re: [devel] [PATCH 1/1] mds: fix mds_tipc_fctrl_shutdown() stuck forever [#3169]

2020-03-30 Thread Thanh Nguyen
PM To: Minh Hon Chau ; Thang Duc Nguyen Cc: opensaf-devel@lists.sourceforge.net Subject: [devel] [PATCH 1/1] mds: fix mds_tipc_fctrl_shutdown() stuck forever [#3169] - Deadlock of portid_map_mutex locking: mds_tipc_fctrl_shutdown() take lock then wait for thread process_all_events() to be can

Re: [devel] [PATCH 1/1] mds: fix mds_tipc_fctrl_shutdown() stuck forever [#3169]

2020-03-30 Thread Thuan Tran
Sent: Tuesday, March 31, 2020 10:01 AM To: Thuan Tran ; Minh Hon Chau ; Thang Duc Nguyen Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [devel] [PATCH 1/1] mds: fix mds_tipc_fctrl_shutdown() stuck forever [#3169] Hi Thuan, I have a minor comment and also an ACK. Dealing with event

Re: [devel] [PATCH 1/1] mds: fix mds_tipc_fctrl_shutdown() stuck forever [#3169]

2020-03-31 Thread minhchau
Hi Thuan, No more comment from me. Thanks Minh On 31/3/20 12:49 pm, Thuan Tran wrote: Hi Minh, See my replies inline. Best Regards, ThuanTr -Original Message- From: Minh Hon Chau Sent: Tuesday, March 31, 2020 8:05 AM To: Thuan Tran ; Thang Duc Nguyen Cc: opensaf-devel@lists.sour