[devel] [PATCH 1 of 1] AMF: support immediate effect when changing hc-type attributes V4 [#819]

2014-06-12 Thread Hans Nordeback
osaf/libs/common/amf/include/amf_defs.h |7 + osaf/services/saf/amf/amfd/hlttype.cc | 72 - osaf/services/saf/amf/amfd/include/node.h |2 + osaf/services/saf/amf/amfd/node.cc|8 + osaf/services/saf/amf/amfnd/di.cc |3 + osaf/s

Re: [devel] [PATCH 1 of 1] AMF: support immediate effect when changing hc-type attributes V4 [#819]

2014-06-18 Thread Nagendra Kumar
Ack. Please update the AMF PR document accordingly. Do you have plans of implementing other types ? If not, then please update the scope of the fix before closing the ticket. Thanks -Nagu > -Original Message- > From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] > Sent: 12 June 20

Re: [devel] [PATCH 1 of 1] AMF: support immediate effect when changing hc-type attributes V4 [#819]

2014-06-18 Thread Hans Feldt
General comment, use NULL instead of 0 See inline for some comments. /HansF > -Original Message- > From: Hans Nordebäck > Sent: den 12 juni 2014 15:51 > To: Hans Feldt; praveen.malv...@oracle.com; nagendr...@oracle.com > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of 1] AMF

Re: [devel] [PATCH 1 of 1] AMF: support immediate effect when changing hc-type attributes V4 [#819]

2014-06-18 Thread Hans Nordebäck
Hi HansF, I have incorporated your comments. Regarding if the set is unique, I realized after sending the patch that a template specialization was missing and changed node.cc accordingly: bool operator<(const AVD_AVND &lhs, AVD_AVND &rhs) { if (strncmp((const char*) lhs.name.value, (const cha

Re: [devel] [PATCH 1 of 1] AMF: support immediate effect when changing hc-type attributes V4 [#819]

2014-06-23 Thread Hans Nordebäck
Hi Nagu, the plan is to implement the types mentioned in the ticket, sutype, su, comptype, comp, hctype, hc and SaAmfCompGlobalAttributes. I would like to push this first patch for hctype now, and create separate patches for each of the other types, is it ok? /Regards HansN -Original Mess

Re: [devel] [PATCH 1 of 1] AMF: support immediate effect when changing hc-type attributes V4 [#819]

2014-06-23 Thread Hans Feldt
OK to push with me I think there is not much left todo except comptype (needs to be sorted out) /HansF > -Original Message- > From: Hans Nordebäck > Sent: den 23 juni 2014 09:29 > To: Nagendra Kumar; Hans Feldt; Praveen Malviya > Cc: opensaf-devel@lists.sourceforge.net > Subject: RE: [PATC