osaf/services/saf/immsv/immnd/ImmModel.cc | 279 -
osaf/services/saf/immsv/immnd/ImmModel.hh | 10 +-
osaf/services/saf/immsv/immnd/immnd_evt.c | 43 -
osaf/services/saf/immsv/immnd/immnd_init.h |6 +-
osaf/tools/safimm/immadm/imm_admin.c | 13 +-
Hi Neel.
There is some valuable work done in this patch and most of it is ok.
But in its current state I have to give it a NACK.
It needs some adjustments and extension before it can be pushed.
There are two main problems:
1) The PBE is the main OI for the object involved and we actually want
Hi AndersBj,
Publish the new patch with the below comments.
Thanks,
Neel.
On Wednesday 23 July 2014 08:34 PM, Anders Bjornerstedt wrote:
> Hi Neel.
>
> There is some valuable work done in this patch and most of it is ok.
> But in its current state I have to give it a NACK.
>
> It needs some adju
osaf/libs/common/immsv/include/immutil.h |4 +
osaf/services/saf/immsv/immnd/ImmModel.cc| 281 ++-
osaf/services/saf/immsv/immnd/ImmModel.hh|8 +-
osaf/services/saf/immsv/immnd/immnd_evt.c| 57 -
osaf/services/saf/immsv/immnd/immnd
Hi Neel,
Good work.
Ack from me on this patch with just the following comment.
If you have time ...
We use four spaces (not tab) as indentation in ImmModel.cc
There are even some accidental indentation changes, where there is no change
except a change of indentation. Such as line 10973 in th
