[devel] [PATCH 1 of 1] IMM: Improved logging at CCB validation error [#669]

2014-02-14 Thread Anders Bjornerstedt
osaf/services/saf/immsv/immnd/ImmModel.cc | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc b/osaf/services/saf/immsv/immnd/ImmModel.cc --- a/osaf/services/saf/immsv/immnd/ImmModel.cc +++ b/osaf/services/saf/immsv/immnd/I

[devel] [PATCH 1 of 1] IMM: Improved logging at CCB validation error [#669]

2014-02-14 Thread Anders Bjornerstedt
osaf/services/saf/immsv/immnd/ImmModel.cc | 27 --- 1 files changed, 20 insertions(+), 7 deletions(-) diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc b/osaf/services/saf/immsv/immnd/ImmModel.cc --- a/osaf/services/saf/immsv/immnd/ImmModel.cc +++ b/osaf/services/s

Re: [devel] [PATCH 1 of 1] IMM: Improved logging at CCB validation error [#669]

2014-02-14 Thread Hans Feldt
Now the syslog message looks like this: Feb 14 15:26:59 SC-1 osafimmnd[1095]: NO Implementer returned error on ccb-completed-callback, Ccb 3 will be aborted I would like to see the word "validation" in the log which is what is used in the specification: SA_AIS_ERR_BAD_OPERATION - The validation

Re: [devel] [PATCH 1 of 1] IMM: Improved logging at CCB validation error [#669]

2014-02-14 Thread Anders Bjornerstedt
I will add the term 'validation error' into the syslog message stemming from the completed continuation. Note that according to the spec, the oi can reply on the completed callback with error codes BAD_OPERATION, NO_RESOURCES or NO_MEMORY. Any other error code will be converted to FAILED_OPERATIO

Re: [devel] [PATCH 1 of 1] IMM: Improved logging at CCB validation error [#669]

2014-02-14 Thread Anders Bjornerstedt
Will send a new patch "shortly". I will discriminate on the error code and report "validation error" only if the OI replied with ERR_BAD_OPERATION. For the other valid erro codes NO_RESOURCES and NO_MEMORY I will report "resource error". Asa bonus I will also include the implementer-name. Timeou