Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations containing more than two OpenSAF 2N SUs [#79]

2016-04-08 Thread Anders Widell
;>> variable(?) or IMM attribute - that would >>>> control this standalone configuration changes to succeed. >>>> >>>> We could think of adding restrictions to cluster-size later on >>>> perhaps. >>>> >>>> Cheers, >>&

Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations containing more than two OpenSAF 2N SUs [#79]

2016-04-04 Thread Anders Widell
size later on perhaps. >>> >>> Cheers, >>> Mathi. >>> >>> >>>> -Original Message- >>>> From: Anders Widell [mailto:anders.wid...@ericsson.com] >>>> Sent: Friday, April 01, 2016 7:28 PM >>>> To: M

Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations containing more than two OpenSAF 2N SUs [#79]

2016-04-04 Thread praveen malviya
second/alternate to take over, etc! >>>> I think this has to be thought through and not just considered as a >>>> matter of 'allowing a configuration change' for a tool to work. >>>> It is another thing that we should discussed this when the asymmetry in

Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations containing more than two OpenSAF 2N SUs [#79]

2016-04-03 Thread Anders Widell
- From: praveen malviya Sent: Friday, April 01, 2016 3:52 PM To: Anders Widell; gary@dektech.com.au; hans.nordeb...@ericsson.com; Nagendra Kumar Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations containing more than two OpenSAF 2N SUs [#79] Please

Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations containing more than two OpenSAF 2N SUs [#79]

2016-04-01 Thread Mathivanan Naickan Palanivelu
To: Mathivanan Naickan Palanivelu; Praveen Malviya; >gary@dektech.com.au; hans.nordeb...@ericsson.com; Nagendra Kumar >Cc: opensaf-devel@lists.sourceforge.net >Subject: Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations >containing more than two OpenSAF 2N SUs [#79] > >Now

Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations containing more than two OpenSAF 2N SUs [#79]

2016-04-01 Thread Anders Widell
Malviya; >> gary....@dektech.com.au; hans.nordeb...@ericsson.com; Nagendra Kumar >> Cc: opensaf-devel@lists.sourceforge.net >> Subject: Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations >> containing more than two OpenSAF 2N SUs [#79] >> >> Today it is p

Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations containing more than two OpenSAF 2N SUs [#79]

2016-04-01 Thread Mathivanan Naickan Palanivelu
u; hans.nordeb...@ericsson.com; Nagendra Kumar >Cc: opensaf-devel@lists.sourceforge.net >Subject: Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations >containing more than two OpenSAF 2N SUs [#79] > >Today it is perfectly possible to configure a 1-node system without using any >

Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations containing more than two OpenSAF 2N SUs [#79]

2016-04-01 Thread Anders Widell
y, April 01, 2016 3:52 PM >> To: Anders Widell; gary....@dektech.com.au; >> hans.nordeb...@ericsson.com; Nagendra Kumar >> Cc: opensaf-devel@lists.sourceforge.net >> Subject: Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations >> containing more than two OpenSAF

Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations containing more than two OpenSAF 2N SUs [#79]

2016-04-01 Thread Mathivanan Naickan Palanivelu
;Cc: opensaf-devel@lists.sourceforge.net >Subject: Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations >containing more than two OpenSAF 2N SUs [#79] > >Please see my comments inline below: > >On 31-Mar-16 6:50 PM, Anders Widell wrote: >> Yes I added the check in the admin

Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations containing more than two OpenSAF 2N SUs [#79]

2016-04-01 Thread praveen malviya
Please see my comments inline below: On 31-Mar-16 6:50 PM, Anders Widell wrote: > Yes I added the check in the admin op as you suggested. But I don't > fully agree that the same check should be done when removing system > controller nodes. With the introduction of this feature, we are starting > t

Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations containing more than two OpenSAF 2N SUs [#79]

2016-03-31 Thread Anders Widell
Yes I added the check in the admin op as you suggested. But I don't fully agree that the same check should be done when removing system controller nodes. With the introduction of this feature, we are starting to move away from the concept of different node types (controller / payload). Indeed,

Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations containing more than two OpenSAF 2N SUs [#79]

2016-03-31 Thread praveen malviya
Hi, In the diff patch, I have seen that admin operation on MW 2N SU is not allowed when more than 2 SUs are configured which translates to the fact that system is running with spare controllers. A similar type of check is needed for deletion of controller configuration from AMF. The check woul

Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations containing more than two OpenSAF 2N SUs [#79]

2016-03-30 Thread Anders Widell
Here is a patch that addresses the review comments from Hans and Praveen. It should be applied on top of the AMF patch that was sent out for review. thanks, Anders Widell On 03/30/2016 04:35 PM, Anders Widell wrote: Hi! See my replies inline, marked [AndersW]. regards, Anders Widell On 03/

Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations containing more than two OpenSAF 2N SUs [#79]

2016-03-30 Thread Anders Widell
Hi! See my replies inline, marked [AndersW]. regards, Anders Widell On 03/17/2016 11:32 AM, praveen malviya wrote: > Hi Anders, > > Please find some comments and queries inline with [Praveen] > > Thanks, > Praveen > > > On 29-Feb-16 8:44 PM, Anders Widell wrote: >> osaf/services/saf/amf/amfd/clm

Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations containing more than two OpenSAF 2N SUs [#79]

2016-03-18 Thread praveen malviya
Hi Anders, Please find some comments and queries inline with [Praveen] Thanks, Praveen On 29-Feb-16 8:44 PM, Anders Widell wrote: > osaf/services/saf/amf/amfd/clm.cc | 21 +- > osaf/services/saf/amf/amfd/include/amfd.h | 2 + > osaf/services/saf/amf/amfd/include/cb.h | 1

Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations containing more than two OpenSAF 2N SUs [#79]

2016-03-15 Thread Hans Nordebäck
ack, code review. MInor comments inlined/Thanks HansN On 02/29/2016 04:14 PM, Anders Widell wrote: > osaf/services/saf/amf/amfd/clm.cc | 21 +- > osaf/services/saf/amf/amfd/include/amfd.h | 2 + > osaf/services/saf/amf/amfd/include/cb.h | 1 + > osaf/services/saf/amf/amfd/i

Re: [devel] [PATCH 1 of 1] amf: Support AMF configurations containing more than two OpenSAF 2N SUs [#79]

2016-03-08 Thread praveen malviya
Hi Anders, When applied over cloud resilience patches (#1620) failures observed for amf patch: Hunk #6 succeeded at 673 (offset 20 lines). 1 out of 6 hunks FAILED -- saving rejects to file osaf/services/saf/amf/amfd/main.cc.rej .. 1 out of 4 hunks FAILED -- saving rejects to file osaf/ser

[devel] [PATCH 1 of 1] amf: Support AMF configurations containing more than two OpenSAF 2N SUs [#79]

2016-02-29 Thread Anders Widell
osaf/services/saf/amf/amfd/clm.cc | 21 +- osaf/services/saf/amf/amfd/include/amfd.h | 2 + osaf/services/saf/amf/amfd/include/cb.h | 1 + osaf/services/saf/amf/amfd/include/role.h | 2 + osaf/services/saf/amf/amfd/main.cc| 78 ++- osaf/service