Subject: Re: [devel] [PATCH 1 of 1] amfd: Add support for admin op result
strings [#85]
On 11/20/2013 08:23 AM, Nagendra Kumar wrote:
Hi Hans,
Sure. Would you like to combine two saflog into one ?
No, please check my patch. I have 2 logs for two reasons 1) to keep some
backwards
: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] amfd: Add support for admin op result
strings [#85]
So before there was a mix of saflog and syslog usage. Upfront errors used was
logged using syslog and later discovered errors logged using saflog. The OK
case went to saflog only
: 20 November 2013 15:53
To: Nagendra Kumar; hans.nordeb...@ericsson.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] amfd: Add support for admin op result
strings [#85]
So before there was a mix of saflog and syslog usage. Upfront errors used was
logged using
2013 14:32
To: hans.fe...@ericsson.com; hans.nordeb...@ericsson.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1 of 1] amfd: Add support for admin op result strings
[#85]
osaf/services/saf/amf/amfd/app.cc| 24 +++---
osaf/services/saf/amf/amfd/cluster.cc| 6
@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] amfd: Add support for admin op result
strings [#85]
Hi,
Just to inform you that I have not converted all Error cases in this
patch.
For example:
In file sg_2n_fsm.cc: function avd_sg_2n_susi_fail_func():
avd_saImmOiAdminOperationResult
: [devel] [PATCH 1 of 1] amfd: Add support for admin op result
strings [#85]
I can see you have pushed but I have some minor improvements that can give us
problems if not fixed now:
1) the saflog call in report_admin_op_error() needs to be protected so it is
not called when the error code is TRYAGAIN
osaf/services/saf/amf/amfd/app.cc| 24 +++---
osaf/services/saf/amf/amfd/cluster.cc| 6 +-
osaf/services/saf/amf/amfd/comp.cc | 36 --
osaf/services/saf/amf/amfd/imm.cc| 41 +
osaf/services/saf/amf/amfd/include/imm.h | 3 +
...@ericsson.com; hans.nordeb...@ericsson.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1 of 1] amfd: Add support for admin op result strings
[#85]
osaf/services/saf/amf/amfd/app.cc| 24 +++---
osaf/services/saf/amf/amfd/cluster.cc| 6 +-
osaf/services/saf/amf/amfd/comp.cc
