Re: [devel] [PATCH 1 of 1] amfd: Range based for loop not correct in map_su_to_node [#1478]

2015-09-16 Thread Nagendra Kumar
Ack. Thanks -Nagu > -Original Message- > From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] > Sent: 14 September 2015 17:54 > To: Praveen Malviya; Nagendra Kumar; gary@dektech.com.au > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of 1] amfd: Range based for loop

Re: [devel] [PATCH 1 of 1] amfd: Range based for loop not correct in map_su_to_node [#1478]

2015-09-15 Thread Hans Nordebäck
Hi Gary, Yes it was wrong before refactoring, I'll correct this before pushing./Thanks HansN -Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: den 15 september 2015 05:43 To: Hans Nordebäck; praveen.malv...@oracle.com; nagendr...@oracle.com Cc:

Re: [devel] [PATCH 1 of 1] amfd: Range based for loop not correct in map_su_to_node [#1478]

2015-09-15 Thread praveen malviya
Ack with one minor comment, code review only. Thanks, Praveen On 14-Sep-15 5:53 PM, Hans Nordeback wrote: > osaf/services/saf/amf/amfd/ckpt_dec.cc | 4 +++- > osaf/services/saf/amf/amfd/node.cc | 2 +- > osaf/services/saf/amf/amfd/sgproc.cc | 4 +++- >

Re: [devel] [PATCH 1 of 1] amfd: Range based for loop not correct in map_su_to_node [#1478]

2015-09-15 Thread Hans Nordebäck
good, I'll update the patch and then I'll push it/Thanks HansN On 09/15/2015 01:22 PM, praveen malviya wrote: > Ack with one minor comment, code review only. > > Thanks, > Praveen > > On 14-Sep-15 5:53 PM, Hans Nordeback wrote: >> osaf/services/saf/amf/amfd/ckpt_dec.cc | 4 +++- >>

Re: [devel] [PATCH 1 of 1] amfd: Range based for loop not correct in map_su_to_node [#1478]

2015-09-14 Thread Gary Lee
Hi Hans Please refer to one comment marked with [GL]. On 14/09/15 22:23, Hans Nordeback wrote: > osaf/services/saf/amf/amfd/ckpt_dec.cc | 4 +++- > osaf/services/saf/amf/amfd/node.cc | 2 +- > osaf/services/saf/amf/amfd/sgproc.cc | 4 +++- > osaf/services/saf/amf/amfd/su.cc