Re: [devel] [PATCH 1 of 1] amfd: Reject admin op if csi add/remove is in progress [#627]

Hi Hans, Thanks for the patch. But, this change is not in scope of this ticket. You can create a ticket for adding su in oper state and we can take test it in those scenarios. Thanks -Nagu -Original Message- From: Hans Feldt [mailto:hans.fe...@ericsson.com] Sent: 21 November

Re: [devel] [PATCH 1 of 1] amfd: Reject admin op if csi add/remove is in progress [#627]

Hi Hans N, Hans F, Any comments on this ? Thanks -Nagu -Original Message- From: Nagendra Kumar Sent: 14 November 2013 17:11 To: hans.fe...@ericsson.com; hans.nordeb...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net Subject: [devel] [PATCH 1 of 1] amfd: Reject admin op if csi

Re: [devel] [PATCH 1 of 1] amfd: Reject admin op if csi add/remove is in progress [#627]

Hi Nagu, I have problem applying the patch, is it for opensaf-4.3.x branch? Which changeset? /BR HansN -Original Message- From: Nagendra Kumar [mailto:nagendr...@oracle.com] Sent: den 20 november 2013 11:05 To: Hans Feldt; Hans Nordebäck Cc: opensaf-devel@lists.sourceforge.net Subject:

Re: [devel] [PATCH 1 of 1] amfd: Reject admin op if csi add/remove is in progress [#627]

Usually we set the SG state non stable when operating on SUs. So why isn't this standard mechanism used in this case? Thanks, Hans On 11/20/2013 11:05 AM, Nagendra Kumar wrote: Hi Hans N, Hans F, Any comments on this ? Thanks -Nagu -Original Message- From: Nagendra Kumar Sent: 14

Re: [devel] [PATCH 1 of 1] amfd: Reject admin op if csi add/remove is in progress [#627]

Don't remember exactly, but may be because of upgrade issue for adding/deleting csi, extra SG fsm state would have been required, so not coded like typical SG fsm style. Thanks -Nagu -Original Message- From: Hans Feldt [mailto:hans.fe...@ericsson.com] Sent: 20 November 2013 18:33 To:

Re: [devel] [PATCH 1 of 1] amfd: Reject admin op if csi add/remove is in progress [#627]

I think SG FSM state SU OPER should be used for this purpose. Could you please test attached patch? It fits better into the code and no new checks needs to be added into admin op handling Thanks, Hans -Original Message- From: Nagendra Kumar [mailto:nagendr...@oracle.com] Sent: den 20

Re: [devel] [PATCH 1 of 1] amfd: Reject admin op if csi add/remove is in progress [#627]

And here's a patch that actually works (previous one didn't). Tested with various CSI add/remove for PI/NPI comps. Please test and comment. If avd_sg_su_oper_list_add() instead was called from inside avd_snd_susi_msg() it would save some lines here and there. /Hans -Original Message-

[devel] [PATCH 1 of 1] amfd: Reject admin op if csi add/remove is in progress [#627]

osaf/services/saf/avsv/avd/avd_csi.c | 18 ++ osaf/services/saf/avsv/avd/avd_sg.c | 7 +++ osaf/services/saf/avsv/avd/avd_si.c | 7 +++ osaf/services/saf/avsv/avd/avd_su.c | 8 osaf/services/saf/avsv/avd/include/avd_csi.h