Re: [devel] [PATCH 1 of 1] amfd: allow change to saAmfSGNumPrefActiveSUs for N+M SG while UNLOCKED [#871]

2014-05-19 Thread Hans Feldt
OK now I see, we should disallow deleting an existing value for saAmfSGNumPrefActiveSUs. That should be done in ccb_completed_modify_hdlr(). Some code can be copied from the apply handler: if ((attr_mod-modType == SA_IMM_ATTR_VALUES_DELETE) || (attribute-attrValues ==

Re: [devel] [PATCH 1 of 1] amfd: allow change to saAmfSGNumPrefActiveSUs for N+M SG while UNLOCKED [#871]

2014-05-16 Thread Nagendra Kumar
Since patch is retaining the older values in case of delete, so that should be ok in case sg is unlock. A notice/warning log is required to be kept to inform user about the same. Thanks -Nagu -Original Message- From: Hans Feldt [mailto:hans.fe...@ericsson.com] Sent: 15 May 2014 17:45

Re: [devel] [PATCH 1 of 1] amfd: allow change to saAmfSGNumPrefActiveSUs for N+M SG while UNLOCKED [#871]

2014-05-15 Thread Nagendra Kumar
Ok, keep a notice log. Ack. Thanks -Nagu -Original Message- From: Alex Jones [mailto:ajo...@genband.com] Sent: 13 May 2014 20:29 To: Nagendra Kumar; hans.fe...@ericsson.com; Praveen Malviya Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1 of 1] amfd: allow change to

Re: [devel] [PATCH 1 of 1] amfd: allow change to saAmfSGNumPrefActiveSUs for N+M SG while UNLOCKED [#871]

2014-05-15 Thread Hans Feldt
if (value_is_deleted) sg-saAmfSGNumPrefActiveSUs = sg-saAmfSGNumPrefActiveSUs; shouldn't it reset the value from the SgType? Thanks, Hans -Original Message- From: Nagendra Kumar [mailto:nagendr...@oracle.com] Sent: den 15 maj 2014 13:56 To: Alex Jones; Hans Feldt; Praveen

Re: [devel] [PATCH 1 of 1] amfd: allow change to saAmfSGNumPrefActiveSUs for N+M SG while UNLOCKED [#871]

2014-05-15 Thread Nagendra Kumar
There is no value corresponding to it in sgtype. -Original Message- From: Hans Feldt [mailto:hans.fe...@ericsson.com] Sent: 15 May 2014 17:22 To: Nagendra Kumar; Alex Jones; Praveen Malviya Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [PATCH 1 of 1] amfd: allow change to

Re: [devel] [PATCH 1 of 1] amfd: allow change to saAmfSGNumPrefActiveSUs for N+M SG while UNLOCKED [#871]

2014-05-15 Thread Hans Feldt
Yeah OK but the default is one(1). Should it be reverted to that or it so that we can't allow to decrease this value? /Hans -Original Message- From: Nagendra Kumar [mailto:nagendr...@oracle.com] Sent: den 15 maj 2014 14:00 To: Hans Feldt; Alex Jones; Praveen Malviya Cc:

Re: [devel] [PATCH 1 of 1] amfd: allow change to saAmfSGNumPrefActiveSUs for N+M SG while UNLOCKED [#871]

2014-05-15 Thread Hans Feldt
Ack, Thanks, Hans -Original Message- From: Alex Jones [mailto:ajo...@genband.com] Sent: den 12 maj 2014 21:06 To: Hans Feldt; nagendr...@oracle.com; praveen.malv...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 1 of 1] amfd: allow change to

Re: [devel] [PATCH 1 of 1] amfd: allow change to saAmfSGNumPrefActiveSUs for N+M SG while UNLOCKED [#871]

2014-05-13 Thread Nagendra Kumar
Hi Alex, I couldn't get the below change: + if (value_is_deleted) + sg-saAmfSGNumPrefActiveSUs = sg-saAmfSGNumPrefActiveSUs; + else Thanks -Nagu -Original Message- From: Alex Jones

Re: [devel] [PATCH 1 of 1] amfd: allow change to saAmfSGNumPrefActiveSUs for N+M SG while UNLOCKED [#871]

2014-05-13 Thread Alex Jones
Oh. That is really to disallow deleting the attribute. Do I even need it? Alex On 05/13/2014 02:15 AM, Nagendra Kumar wrote: Hi Alex, I couldn't get the below change: + if (value_is_deleted) + sg-saAmfSGNumPrefActiveSUs =

[devel] [PATCH 1 of 1] amfd: allow change to saAmfSGNumPrefActiveSUs for N+M SG while UNLOCKED [#871]

2014-05-12 Thread Alex Jones
osaf/services/saf/amf/amfd/sg.cc | 39 +++ 1 files changed, 39 insertions(+), 0 deletions(-) ccb_completed_modify_hdlr: Attribute 'saAmfSGNumPrefActiveSUs' cannot be modified when SG is unlocked OpenSAF disallows changing saAmfSGNumPrefActiveSUs while the