Re: [devel] [PATCH 1 of 1] amfd: create comp if not found during decoding [#761]

2014-02-06 Thread praveen malviya
Ack. Thanks, Praveen On 03-Feb-14 3:44 PM, nagendr...@oracle.com wrote: osaf/services/saf/amf/amfd/ckpt_dec.cc| 5 + osaf/services/saf/amf/amfd/comp.cc| 21 + osaf/services/saf/amf/amfd/include/comp.h | 1 + 3 files changed, 23 insertions(+), 4

Re: [devel] [PATCH 1 of 1] amfd: create comp if not found during decoding [#761]

2014-02-06 Thread Nagendra Kumar
Any comments ?? -Original Message- From: Nagendra Kumar Sent: 04 February 2014 14:02 To: Hans Feldt; Hans Nordebäck; Praveen Malviya Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1 of 1] amfd: create comp if not found during decoding [#761] Hum, would wait

Re: [devel] [PATCH 1 of 1] amfd: create comp if not found during decoding [#761]

2014-02-05 Thread Hans Feldt
On 02/04/2014 09:31 AM, Nagendra Kumar wrote: Hum, would wait for that. Here I am not able to understand your comments, please elaborate on that. Do you mean to break short or long commit message into three parts and name the sections? Give some example. OK here's a try for this ticket:

Re: [devel] [PATCH 1 of 1] amfd: create comp if not found during decoding [#761]

2014-02-04 Thread Nagendra Kumar
Hum, would wait for that. Here I am not able to understand your comments, please elaborate on that. Do you mean to break short or long commit message into three parts and name the sections? Give some example. Thanks -Nagu -Original Message- From: Hans Feldt

[devel] [PATCH 1 of 1] amfd: create comp if not found during decoding [#761]

2014-02-03 Thread nagendra . k
osaf/services/saf/amf/amfd/ckpt_dec.cc| 5 + osaf/services/saf/amf/amfd/comp.cc| 21 + osaf/services/saf/amf/amfd/include/comp.h | 1 + 3 files changed, 23 insertions(+), 4 deletions(-) Some times, because of timing issues, apply callback is reaching

Re: [devel] [PATCH 1 of 1] amfd: create comp if not found during decoding [#761]

2014-02-03 Thread Anders Björnerstedt
it is interested in monitoring. /AndersBj -Original Message- From: nagendr...@oracle.com [mailto:nagendr...@oracle.com] Sent: den 3 februari 2014 11:15 To: Hans Feldt; Hans Nordebäck; praveen.malv...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [devel] [PATCH 1 of 1] amfd: create

Re: [devel] [PATCH 1 of 1] amfd: create comp if not found during decoding [#761]

2014-02-03 Thread Hans Feldt
Please send a new patch with a corrected commit message, for defects it should contain 3 paragraphs: symptom, analysis and change description. See inline for comments. during decoding = during checkpointing? Thanks, Hans -Original Message- From: nagendr...@oracle.com

Re: [devel] [PATCH 1 of 1] amfd: create comp if not found during decoding [#761]

2014-02-03 Thread Nagendra Kumar
for defects it should contain 3 paragraphs: symptom, analysis and change description Do we have this informed to developers or written some where ? Thanks -Nagu -Original Message- From: Hans Feldt [mailto:hans.fe...@ericsson.com] Sent: 04 February 2014 01:58 To: Nagendra Kumar;