Re: [devel] [PATCH 1 of 1] amfd: fix SU constructor [#713]

2014-05-28 Thread Hans Nordebäck
:58 To: Hans Feldt; Hans Nordebäck Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [devel] [PATCH 1 of 1] amfd: fix SU constructor [#713] Can you please share the advantage for using 'explicit' here: + explicit AVD_SU(const SaNameT *dn); Thanks -Nagu -Original Message- From

Re: [devel] [PATCH 1 of 1] amfd: fix SU constructor [#713]

2014-05-28 Thread Hans Nordebäck
ack, two minor comments: 1. specify the initializers in declaration order, (thats how they get called). 2. if, as also IngvarB pointed out, SaNameT contained a default constructor initializing its length to 0, it don't need to be initialized in the class. I have already sent out a patch for

Re: [devel] [PATCH 1 of 1] amfd: fix SU constructor [#713]

2014-05-28 Thread Hans Nordebäck
-Original Message- From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] Sent: 28 May 2014 16:39 To: Nagendra Kumar; Hans Feldt Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [devel] [PATCH 1 of 1] amfd: fix SU constructor [#713] Hi Nagu, I think it is good practice to use