[devel] [PATCH 1 of 1] amfd: replace patricia tree with stl::maps in nodegroup [#713]

2014-05-23 Thread nagendra . k
osaf/services/saf/amf/amfd/include/node.h | 2 +- osaf/services/saf/amf/amfd/nodegroup.cc | 76 -- 2 files changed, 22 insertions(+), 56 deletions(-) diff --git a/osaf/services/saf/amf/amfd/include/node.h b/osaf/services/saf/amf/amfd/include/node.h ---

Re: [devel] [PATCH 1 of 1] amfd: replace patricia tree with stl::maps in nodegroup [#713]

2014-05-23 Thread Hans Feldt
Ack with minor comments inline /Hans -Original Message- From: nagendr...@oracle.com [mailto:nagendr...@oracle.com] Sent: den 23 maj 2014 10:45 To: Hans Feldt; Hans Nordebäck; praveen.malv...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 1 of 1] amfd: replace

Re: [devel] [PATCH 1 of 1] amfd: replace patricia tree with stl::maps in nodegroup [#713]

2014-05-22 Thread Hans Nordebäck
I agree with HansF, we should use the provided iterator. /Regards HansN On 05/21/14 14:38, Hans Feldt wrote: getnext is not needed. Maps have a built in iterator that can/should be used directly At least that is the pattern followed so far. /HansF -Original Message- From:

[devel] [PATCH 1 of 1] amfd: replace patricia tree with stl::maps in nodegroup [#713]

2014-05-21 Thread nagendra . k
osaf/services/saf/amf/amfd/include/db_template.h | 17 ++ osaf/services/saf/amf/amfd/include/node.h| 2 +- osaf/services/saf/amf/amfd/nodegroup.cc | 61 ++- 3 files changed, 35 insertions(+), 45 deletions(-) diff --git

Re: [devel] [PATCH 1 of 1] amfd: replace patricia tree with stl::maps in nodegroup [#713]

2014-05-21 Thread Hans Feldt
getnext is not needed. Maps have a built in iterator that can/should be used directly At least that is the pattern followed so far. /HansF -Original Message- From: nagendr...@oracle.com [mailto:nagendr...@oracle.com] Sent: den 21 maj 2014 12:00 To: Hans Feldt; Hans Nordebäck;