Please find comments inline with [Praveen].
Thanks,
Praveen
On 26-Mar-14 4:57 PM, Hans Nordeback wrote:
osaf/services/saf/amf/amfd/include/db_template.h | 63
1 files changed, 63 insertions(+), 0 deletions(-)
diff --git
To: Hans Nordebäck
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] amfd: use template class db to replace
patricia tree db V2 [#713]
Please find comments inline with [Praveen].
Thanks,
Praveen
On 26-Mar-14 4:57 PM, Hans Nordeback wrote:
osaf/services/saf/amf/amfd/include
Message-
From: Zoran Milinkovic
Sent: den 4 april 2014 15:48
To: praveen malviya; Hans Nordebäck
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1 of 1] amfd: use template class db to replace
patricia tree db V2 [#713]
+ typename AmfDbMap::iterator it = db.find(name
Just some thoughts regarding NULL pointers:
When I write a function, I by default assume that pointers passed to it
as arguments are not NULL. Only if the API documentation explicitly
states that a NULL pointer is a valid input for that argument, then the
function needs to handle it. Otherwise
; Hans Feldt; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] amfd: use template class db to replace
patricia tree db V2 [#713]
Just some thoughts regarding NULL pointers:
When I write a function, I by default assume that pointers passed
@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] amfd: use template class db to replace
patricia tree db V2 [#713]
Asserts are fine even if the input is supposed to already be validated.
But as I said, asserting that a pointer is not NULL is not so useful since you
crash anyway when dereferencing
Ack
I guess later we need to make this file common between director and node
director.
Thanks,
Hans
On 03/26/2014 12:27 PM, Hans Nordeback wrote:
osaf/services/saf/amf/amfd/include/db_template.h | 63
1 files changed, 63 insertions(+), 0 deletions(-)
diff
osaf/services/saf/amf/amfd/include/db_template.h | 63
1 files changed, 63 insertions(+), 0 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/db_template.h
b/osaf/services/saf/amf/amfd/include/db_template.h
new file mode 100644
--- /dev/null
+++
