Re: [devel] [PATCH 1 of 1] amfd: validate NG admin state at the time of creation [#1560]

2015-10-29 Thread Hans Nordebäck
ack, code review only/Thanks Hans On 10/29/2015 06:24 AM, praveen.malv...@oracle.com wrote: > osaf/services/saf/amf/amfd/nodegroup.cc | 10 -- > osaf/services/saf/amf/amfd/util.cc | 2 +- > 2 files changed, 9 insertions(+), 3 deletions(-) > > > AMF allows creation of NG with

Re: [devel] [PATCH 1 of 1] amfd: validate NG admin state at the time of creation [#1560]

2015-10-29 Thread Gary Lee
ack (review only) > On 29 Oct 2015, at 4:24 PM, praveen.malv...@oracle.com wrote: > > osaf/services/saf/amf/amfd/nodegroup.cc | 10 -- > osaf/services/saf/amf/amfd/util.cc | 2 +- > 2 files changed, 9 insertions(+), 3 deletions(-) > > > AMF allows creation of NG with invalid

[devel] [PATCH 1 of 1] amfd: validate NG admin state at the time of creation [#1560]

2015-10-28 Thread praveen . malviya
osaf/services/saf/amf/amfd/nodegroup.cc | 10 -- osaf/services/saf/amf/amfd/util.cc | 2 +- 2 files changed, 9 insertions(+), 3 deletions(-) AMF allows creation of NG with invalid admin state. Check is missing in CCB completed callback. Patch adds the required check. diff