ack, code review only/Thanks HansN
On 01/29/2015 09:39 AM, nagendr...@oracle.com wrote:
> osaf/services/saf/amf/amfnd/clc.cc | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
>
> Amfnd is asserting when it gets instantiate success
> event during node failover. This was done in the assumption
> that no other event(other than cleanup, cleanup succ or fail)
> is expected to come during node failover.
> But there may be scenarios, where such events can come, so
> it is not relevant for Amfnd to assert. Rather Amfnd can ignore them.
>
> diff --git a/osaf/services/saf/amf/amfnd/clc.cc
> b/osaf/services/saf/amf/amfnd/clc.cc
> --- a/osaf/services/saf/amf/amfnd/clc.cc
> +++ b/osaf/services/saf/amf/amfnd/clc.cc
> @@ -801,8 +801,9 @@ uint32_t avnd_comp_clc_fsm_run(AVND_CB *
> case AVND_COMP_CLC_PRES_FSM_EV_CLEANUP:
> break;
> default:
> - osafassert(0);
> - break;
> + LOG_ER("Ignoring event '%s' for '%s' during node
> failover",
> + pres_state_evt[ev], comp->name.value);
> + goto done;
> }
> }
>
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
