Re: [devel] [PATCH 1 of 1] core: Add unit test for sysf_ipc.c V3 [#1520]

2016-01-04 Thread Mathivanan Naickan Palanivelu
Ack, Mathi. > -Original Message- > From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] > Sent: Wednesday, November 25, 2015 11:03 PM > To: Mathivanan Naickan Palanivelu; Ramesh Babu Betham; > anders.wid...@ericsson.com > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of

Re: [devel] [PATCH 1 of 1] core: Add unit test for sysf_ipc.c V3 [#1520]

2015-12-07 Thread Anders Widell
Ack, with minor comments: 1) Maybe rename the test_sysf_ipc.cc file to sysf_ipc_test.cc, to be better aligned with common practice of adding _test at the end of the file name? 2) The commit message should not have statements like "Updated to use c++11 ..." or "Updated with review comments" mix

[devel] [PATCH 1 of 1] core: Add unit test for sysf_ipc.c V3 [#1520]

2015-11-25 Thread Hans Nordeback
configure.ac |1 + osaf/libs/core/leap/Makefile.am|2 +- osaf/libs/core/leap/tests/Makefile.am | 51 + osaf/libs/core/leap/tests/test_sysf_ipc.cc | 273 + 4 files changed, 326 insertions(+), 1 deletions(-)