Hi Mathi,
Can you please explain what maintainability problems that we will get because
of this way of checkpointing?
By the way you said that you needed some more time to review #593 "#593 needs
more effort, will prioritize to close it on Monday(28th)". Can you say when
that can be?
Thanks
Hi Lennart,
Oops, I seemed to have replied to the wrong thread.
My ACK was meant for #593.
W.r.t the backward compatibility comment,
Yes, you might remember my comments on using MDS versioning or MBCSv scheme.
Like I said, there was need to create a new mechanism in logsv to start with.
I have acked on #593 separately.
That's a mix up :-)
Mathi.
> -Original Message-
> From: Mathivanan Naickan Palanivelu
> Sent: Monday, August 31, 2015 8:58 PM
> To: Lennart Lund; Giang Do T; Vu Nguyen M
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [devel] [PATCH 1 of 1] log:
Hi Lennart,
Tested and Acked from me.
There are some minor comments in lines.
Best Regards,
Giang Do
On 25/08/2015 20:26, Lennart Lund wrote:
> osaf/services/saf/logsv/README | 21 +
> osaf/services/saf/logsv/lgs/lgs_config.c | 50 +-
>
ACK,
On a different topic, I think we should remove this way of checkpointing!
We would end up(if not already) creating maintainability problems,
We should rather use the versioning scheme of mds or mbcsv to perform the
checkpointing.
Thanks,
Mathi.
> -Original Message-
> From: giang
Hi,
With this patch, the lowest value for `logMaxLogrecsize` in the validation
is set to `256`.
But in logsv class definition, the default value of `
saLogStreamFixedLogRecordSize` is set to `150`.
I think the lowest value for ` logMaxLogrecsize` should be changed to `150`
instead.
Regards,
Vu
Hi Lennart,
Ack after converging on the following minor comments inline:
- vu.m.ngu...@dektech.com.au wrote:
Hi,
With this patch, the lowest value for `logMaxLogrecsize` in the
validation
is set to `256`.
But in logsv class definition, the default value of `
osaf/services/saf/logsv/README | 21 +
osaf/services/saf/logsv/lgs/lgs_config.c | 50 +-
osaf/services/saf/logsv/lgs/lgs_config.h |1 +
osaf/services/saf/logsv/lgs/lgs_file.c |1 +
osaf/services/saf/logsv/lgs/lgs_imm.c| 224 +---
tests/logsv/logtest.c
