Re: [devel] [PATCH 1 of 1] ntf: fix ntfa does not remove subscriber in subscriberNoList at finalize [#1978]

2016-10-10 Thread minh chau
Hi Canh, Ack from me Thanks, Minh On 28/09/16 13:35, Canh Van Truong wrote: > osaf/libs/agents/saf/ntfa/ntfa_api.c | 2 + > osaf/libs/agents/saf/ntfa/ntfa_util.c| 68 > +++ > tests/ntfsv/tet_saNtfNotificationSubscribe.c | 32 + > 3 fi

Re: [devel] [PATCH 1 of 1] ntf: fix ntfa does not remove subscriber in subscriberNoList at finalize [#1978]

2016-10-07 Thread praveen malviya
Ack from me. Please update the note in saNtfFinalize() header. Thanks, Praveen On 06-Oct-16 9:12 AM, Canh Truong wrote: > Hi Praveen, > > What I understand about deadlock as below: > > When other API and saNtfFinalize() called in parallel, both take the > ntfhandle by ncshm_take_hdl(), the cell

Re: [devel] [PATCH 1 of 1] ntf: fix ntfa does not remove subscriber in subscriberNoList at finalize [#1978]

2016-10-05 Thread Canh Truong
Hi Praveen, What I understand about deadlock as below: When other API and saNtfFinalize() called in parallel, both take the ntfhandle by ncshm_take_hdl(), the cell->use_ct increase (and > 1). The saNtfFinalize() call ncshm_destroy_hdl() to destroy ntfhandle, but ncshm_destroy_hdl() will check ce

Re: [devel] [PATCH 1 of 1] ntf: fix ntfa does not remove subscriber in subscriberNoList at finalize [#1978]

2016-10-05 Thread praveen malviya
Hi Canh, Please find one comment inline with [Praveen]. Thanks, Praveen On 28-Sep-16 9:05 AM, Canh Van Truong wrote: > osaf/libs/agents/saf/ntfa/ntfa_api.c | 2 + > osaf/libs/agents/saf/ntfa/ntfa_util.c| 68 > +++ > tests/ntfsv/tet_saNtfNotificationSu

[devel] [PATCH 1 of 1] ntf: fix ntfa does not remove subscriber in subscriberNoList at finalize [#1978]

2016-09-27 Thread Canh Van Truong
osaf/libs/agents/saf/ntfa/ntfa_api.c | 2 + osaf/libs/agents/saf/ntfa/ntfa_util.c| 68 +++ tests/ntfsv/tet_saNtfNotificationSubscribe.c | 32 + 3 files changed, 81 insertions(+), 21 deletions(-) In finalize(), ntfa deletes client and does n