[devel] [PATCH 1 of 3] avsv: include and use sirank in SUSI msg [#574]

2014-04-06 Thread Hans Feldt
osaf/libs/common/avsv/avsv_d2nedu.c| 35 ++--- osaf/libs/common/avsv/include/avsv_d2nmsg.h| 5 +- osaf/services/saf/avsv/avd/avd_mds.c | 11 +++-- osaf/services/saf/avsv/avd/avd_util.c | 1 + osaf/services/saf/avsv/avd/include/avd_mds.h | 2

Re: [devel] [PATCH 1 of 3] avsv: include and use sirank in SUSI msg [#574]

2014-04-07 Thread praveen malviya
I have a doubt in-lined with [Praveen] Thanks, Praveen On 07-Apr-14 11:05 AM, Hans Feldt wrote: > osaf/libs/common/avsv/avsv_d2nedu.c| 35 ++--- > osaf/libs/common/avsv/include/avsv_d2nmsg.h| 5 +- > osaf/services/saf/avsv/avd/avd_mds.c | 11 +++-- >

Re: [devel] [PATCH 1 of 3] avsv: include and use sirank in SUSI msg [#574]

2014-04-07 Thread Nagendra Kumar
I didn't get an addition of avd_avnd_msg_fmt_map_table ? > -Original Message- > From: praveen malviya > Sent: 07 April 2014 14:55 > To: Hans Feldt > Cc: Nagendra Kumar; hans.nordeb...@ericsson.com; opensaf- > de...@lists.sourceforge.net > Subject: Re: [PATCH 1 of 3] avsv: include and use s

Re: [devel] [PATCH 1 of 3] avsv: include and use sirank in SUSI msg [#574]

2014-04-07 Thread Hans Feldt
On 04/07/2014 11:24 AM, praveen malviya wrote: > I have a doubt in-lined with [Praveen] > > Thanks, > Praveen > On 07-Apr-14 11:05 AM, Hans Feldt wrote: >>osaf/libs/common/avsv/avsv_d2nedu.c| 35 ++--- >>osaf/libs/common/avsv/include/avsv_d2nmsg.h| 5 +- >>

Re: [devel] [PATCH 1 of 3] avsv: include and use sirank in SUSI msg [#574]

2014-04-07 Thread Hans Feldt
See previous mail. /Hans On 04/07/2014 11:38 AM, Nagendra Kumar wrote: > I didn't get an addition of avd_avnd_msg_fmt_map_table ? > >> -Original Message- >> From: praveen malviya >> Sent: 07 April 2014 14:55 >> To: Hans Feldt >> Cc: Nagendra Kumar; hans.nordeb...@ericsson.com; opensaf- >>

Re: [devel] [PATCH 1 of 3] avsv: include and use sirank in SUSI msg [#574]

2014-04-07 Thread SuryaNarayana Garlapati
Nack. Following points needs to be considered. 1. As there is a change in messaging change with the AVD, You should bump up the AVD MDS Sub part version. 2. As there is no change in AVND messaging, its MDS sub part version should not be changed. Attached is modified patch. I had tested 4.3 a

Re: [devel] [PATCH 1 of 3] avsv: include and use sirank in SUSI msg [#574]

2014-04-07 Thread SuryaNarayana Garlapati
After further testing, i found that si rank is always being read from IMM. Will update you more on this. As of now, please hold for some time. On Monday 07 April 2014 06:12 PM, SuryaNarayana Garlapati wrote: > Nack. > > Following points needs to be considered. > > 1. As there is a change in messa

Re: [devel] [PATCH 1 of 3] avsv: include and use sirank in SUSI msg [#574]

2014-04-07 Thread Hans Feldt
Re: [devel] [PATCH 1 of 3] avsv: include and use sirank in SUSI msg > [#574] > > Nack. > > Following points needs to be considered. > > 1. As there is a change in messaging change with the AVD, You should > bump up the AVD MDS Sub part version. [Hans] why is that require

Re: [devel] [PATCH 1 of 3] avsv: include and use sirank in SUSI msg [#574]

2014-04-08 Thread SuryaNarayana Garlapati
I Tested your patch and it works because of the bug in the existing code where the AVD subpart version is incremented but not the Max version(in previous release). Any way, Ideal way of implementing a change in messaging part between x and y is 1. Increment the subpart version of both the servic

Re: [devel] [PATCH 1 of 3] avsv: include and use sirank in SUSI msg [#574]

2014-04-08 Thread praveen malviya
Ack for all the three patches in this series. Tested by bringing up two controllers one with version 4.3 (latest change set) and another with 4.4 (latest change set). Thanks, Praveen On 07-Apr-14 11:05 AM, Hans Feldt wrote: > osaf/libs/common/avsv/avsv_d2nedu.c| 35 ++-

Re: [devel] [PATCH 1 of 3] avsv: include and use sirank in SUSI msg [#574]

2014-04-11 Thread Hans Feldt
On 8 April 2014 11:55, SuryaNarayana Garlapati wrote: > I Tested your patch and it works because of the bug in the existing code > where the AVD subpart version is incremented but not the Max version(in > previous release). Can you point to the exact code location? Can this be corrected? > > An

Re: [devel] [PATCH 1 of 3] avsv: include and use sirank in SUSI msg [#574]

2014-04-18 Thread SuryaNarayana Garlapati
On Friday 11 April 2014 12:52 PM, Hans Feldt wrote: > On 8 April 2014 11:55, SuryaNarayana Garlapati > wrote: >> I Tested your patch and it works because of the bug in the existing code >> where the AVD subpart version is incremented but not the Max version(in >> previous release). > Can you poin