Re: [devel] [PATCH 2 of 2] clm: Supervise and when necessary activate system controller functionality [#79]

2016-03-31 Thread Anders Widell
Ok, sure. But in that case I would argue that we keep the wrappers. I don't see re-writing this piece of code in C as an alternative - it would be a step in the wrong direction. I am using std::set in this code, and yes, of course there are implementations of common data structures like sets an

Re: [devel] [PATCH 2 of 2] clm: Supervise and when necessary activate system controller functionality [#79]

2016-03-31 Thread Mathivanan Naickan Palanivelu
Hi Anders, Thanks. But I don't intend to use this patch yet. The reasons being I have already been working on some changes For the next release and I don't want those to be disturbed; secondly If I intend to convert, I would Prefer to have a plan and not do it on the fly. So, you please go ahe

Re: [devel] [PATCH 2 of 2] clm: Supervise and when necessary activate system controller functionality [#79]

2016-03-31 Thread Anders Widell
Hi! I did a quick stab at converting the CLM node agent to C++, and here is the result (without the wrappers). Apply it on top of the patch that is already on review. Due to the stricter type checking in C++, I actually bumped into a potential bug: The function clmna_process_dummyup_msg() is

Re: [devel] [PATCH 2 of 2] clm: Supervise and when necessary activate system controller functionality [#79]

2016-03-31 Thread Anders Widell
I don't like the wrappers either. :-) The alternative is to convert the whole CLM service to C++, in which case the wrappers will go away. I think this is the approach to take if you wish to get rid of the wrappers. / Anders W On 03/31/2016 03:08 PM, Mathivanan Naickan Palanivelu wrote: > Ack f

Re: [devel] [PATCH 2 of 2] clm: Supervise and when necessary activate system controller functionality [#79]

2016-03-31 Thread Mathivanan Naickan Palanivelu
Ack for the functional change related to startup and the idea of election. But, I do not favour introducing wrapper files. I will try to give a c version of The election code by tomorrow, if not we can push patch 2 tomorrow and we can take it up after FC. Cheers, Mathi. >-Original Messag

[devel] [PATCH 2 of 2] clm: Supervise and when necessary activate system controller functionality [#79]

2016-02-29 Thread Anders Widell
osaf/services/infrastructure/nid/config/nodeinit.conf.controller |2 +- osaf/services/saf/clmsv/config/clmna.conf|8 + osaf/services/saf/clmsv/nodeagent/Makefile.am| 11 +- osaf/services/saf/clmsv/nodeagent/cb.h |1