since they have the same data. I
> don't see the issue/problem. Please explain it to me.
>
> Thanks,
> Hans
>
>
>> -Original Message-
>> From: praveen malviya [mailto:praveen.malv...@oracle.com]
>> Sent: den 17 juni 2014 06:28
>> To: Hans Nord
Thanks,
Hans
> -Original Message-
> From: praveen malviya [mailto:praveen.malv...@oracle.com]
> Sent: den 17 juni 2014 06:28
> To: Hans Nordebäck
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [devel] [PATCH 2 of 4] amfd: add specialized red model
> specific S
Message-
> From: praveen malviya [mailto:praveen.malv...@oracle.com]
> Sent: den 17 juni 2014 06:28
> To: Hans Nordebäck
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [devel] [PATCH 2 of 4] amfd: add specialized red model specific
> SG classes [#713]
>
>
>
On 16-Jun-14 6:58 PM, Hans Nordebäck wrote:
> Hi, a few comments, looking at the amf spec. isn't it more natural to:
>
> class SaAmfSGType
>
> class SG_2N : public SaAmfSGType
> class SG_NORED : public SaAmfSGType
> etc?
>
> What about a factory class, e.g. SaAmfSGTypeFactory that creates concret
Hi, a few comments, looking at the amf spec. isn't it more natural to:
class SaAmfSGType
class SG_2N : public SaAmfSGType
class SG_NORED : public SaAmfSGType
etc?
What about a factory class, e.g. SaAmfSGTypeFactory that creates concrete
SaAmfSGTypes types?
/Regards HansN
-Original Mess
: Hans Feldt
>> Cc: opensaf-devel@lists.sourceforge.net
>> Subject: Re: [devel] [PATCH 2 of 4] amfd: add specialized red model
>> specific SG classes [#713]
>>
>> Please find comments inline with [Praveen]
>>
>> Thanks,
>> Praveen
>> On 16-Jun-
classes [#713]
Inline
Thanks,
Hans
> -Original Message-
> From: praveen malviya [mailto:praveen.malv...@oracle.com]
> Sent: den 16 juni 2014 11:49
> To: Hans Feldt
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [devel] [PATCH 2 of 4] amfd: add specialized red mo
Inline
Thanks,
Hans
> -Original Message-
> From: praveen malviya [mailto:praveen.malv...@oracle.com]
> Sent: den 16 juni 2014 11:49
> To: Hans Feldt
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [devel] [PATCH 2 of 4] amfd: add specialized red model specific
Please find comments inline with [Praveen]
Thanks,
Praveen
On 16-Jun-14 10:37 AM, Hans Feldt wrote:
> osaf/services/saf/amf/amfd/ckpt_dec.cc | 4 +-
> osaf/services/saf/amf/amfd/include/sg.h | 48
> +--
> osaf/services/saf/amf/amfd/sg.cc | 36
osaf/services/saf/amf/amfd/ckpt_dec.cc | 4 +-
osaf/services/saf/amf/amfd/include/sg.h | 48 +--
osaf/services/saf/amf/amfd/sg.cc | 36 +++-
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 4 ++
osaf/services/saf/amf/amfd/sg_nored
osaf/services/saf/amf/amfd/ckpt_dec.cc | 4 +-
osaf/services/saf/amf/amfd/include/sg.h | 54 +--
osaf/services/saf/amf/amfd/sg.cc | 36 +
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 4 ++
osaf/services/saf/amf/amfd/sg_nored_fs
11 matches
Mail list logo
