Re: [devel] [PATCH 2 of 5] amfnd: store amfd mds ver [#574]

2014-04-04 Thread SuryaNarayana Garlapati
pensaf-devel@lists.sourceforge.net >> Subject: Re: [devel] [PATCH 2 of 5] amfnd: store amfd mds ver [#574] >> >> Hi Hans, >> Comments/answers inline. >> >> Regards >> Surya >> On Friday 04 April 2014 11:16 AM, Hans Feldt wrote: >>> Hi, >

Re: [devel] [PATCH 2 of 5] amfnd: store amfd mds ver [#574]

2014-04-03 Thread Hans Feldt
ts.sourceforge.net > Subject: Re: [devel] [PATCH 2 of 5] amfnd: store amfd mds ver [#574] > > Hi Hans, > Comments/answers inline. > > Regards > Surya > On Friday 04 April 2014 11:16 AM, Hans Feldt wrote: > > Hi, > > I interpreted your answer such that there are two alte

Re: [devel] [PATCH 2 of 5] amfnd: store amfd mds ver [#574]

2014-04-03 Thread SuryaNarayana Garlapati
Hi Hans, Comments/answers inline. Regards Surya On Friday 04 April 2014 11:16 AM, Hans Feldt wrote: > Hi, > I interpreted your answer such that there are two alternatives: > 1) rely on mds sub part version but then I need to handle NEW-ACTIVE or > 2) use message format version instead > > Seems li

Re: [devel] [PATCH 2 of 5] amfnd: store amfd mds ver [#574]

2014-04-03 Thread Hans Feldt
Hi, I interpreted your answer such that there are two alternatives: 1) rely on mds sub part version but then I need to handle NEW-ACTIVE or 2) use message format version instead Seems like you had a preference for 2? Any alternative seems to require quite a few more changes in amfnd. Alt1 would n

Re: [devel] [PATCH 2 of 5] amfnd: store amfd mds ver [#574]

2014-04-03 Thread Hans Feldt
Thanks, that's a good comment. Need to think what the best way forward is. The change will most likely affect the rest of patch series. Skickat från min Sony Xperia™-smartphone SuryaNarayana Garlapati skrev Comments: 1. First of all, the mds sub part version should not be stored/used

Re: [devel] [PATCH 2 of 5] amfnd: store amfd mds ver [#574]

2014-04-03 Thread SuryaNarayana Garlapati
Comments: 1. First of all, the mds sub part version should not be stored/used. You should depend on the message format version as SI rank is being embedded in the new message(which is being sent from AVD). If you have a requirement for usage of message version, you can get it at runtime when y

[devel] [PATCH 2 of 5] amfnd: store amfd mds ver [#574]

2014-03-28 Thread Hans Feldt
osaf/services/saf/avsv/avd/avd_mds.c | 2 ++ osaf/services/saf/avsv/avnd/avnd_di.c | 1 + osaf/services/saf/avsv/avnd/avnd_mds.c | 3 +++ osaf/services/saf/avsv/avnd/include/avnd_cb.h | 1 + osaf/services/saf/avsv/avnd/include/avnd_evt.h | 1 + 5 files changed, 8 i