Re: [devel] [PATCH 3/3] base: Use the OpenSAF internal log service for trace [#2165]

2017-10-17 Thread Anders Widell
Ok will change these, except using std::unique_ptr since Google C++ Style Guide discourages usage of class type with static storage duration. regards, Anders Widell On 10/17/2017 10:43 AM, Hans Nordebäck wrote: ack, code review only. Minor comments below. /Thanks HansN On 10/10/2017 06:44

Re: [devel] [PATCH 3/3] base: Use the OpenSAF internal log service for trace [#2165]

2017-10-17 Thread Hans Nordebäck
ack, code review only. Minor comments below. /Thanks HansN On 10/10/2017 06:44 PM, Anders Widell wrote: Instead of writing trace messages directly to a file, use the OpenSAF internal log service which is implemented in osaftransportd. As a consequence, the trace files will now be rotated automa

[devel] [PATCH 3/3] base: Use the OpenSAF internal log service for trace [#2165]

2017-10-10 Thread Anders Widell
Instead of writing trace messages directly to a file, use the OpenSAF internal log service which is implemented in osaftransportd. As a consequence, the trace files will now be rotated automatically when they have exceeded the maximum allowed log file size. --- src/base/logtrace.cc | 280 +