-Original Message-
From: Hans Feldt [mailto:hans.fe...@ericsson.com]
Sent: 14 May 2014 11:31
To: Nagendra Kumar; Hans Feldt; Hans Nordebäck
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 3 of 5] amfd: move supreinst logic from comp to su
[#713
Ok. Ack
-Original Message-
From: Hans Feldt [mailto:hans.fe...@ericsson.com]
Sent: 14 May 2014 16:00
To: Nagendra Kumar; Hans Feldt; Hans Nordebäck
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 3 of 5] amfd: move supreinst logic from comp to su
[#713
1. Not sure, why you have moved the logic to su from comp. Since component
being added in su makes difference of PI/NPI SU. Ideally the code should have
been in su.
2. Removing logic whether su is being deleted, will result in
ERROR_NOT_EXIST in rt update of su. Any specific reason
osaf/services/saf/amf/amfd/comp.cc | 65 +++-
osaf/services/saf/amf/amfd/include/su.h | 1 +
osaf/services/saf/amf/amfd/su.cc| 39 ++-
3 files changed, 43 insertions(+), 62 deletions(-)
Comp was directly manipulating SU data, this is
