t; > Cc: opensaf-devel@lists.sourceforge.net
> > Subject: RE: [devel] [PATCH 4 of 7] amfd: add SU constr/destr [#713]
> >
> >
> >
> > > -Original Message-
> > > From: Nagendra Kumar [mailto:nagendr...@oracle.com]
> > > Sent: den 2
, Hans Feldt wrote:
>
>> -Original Message-
>> From: Nagendra Kumar [mailto:nagendr...@oracle.com]
>> Sent: den 2 maj 2014 12:31
>> To: Hans Feldt; Praveen Malviya; Hans Nordebäck
>> Cc: opensaf-devel@lists.sourceforge.net
>> Subject: Re: [devel] [PATCH
Ok.
-Nagu
> -Original Message-
> From: Hans Feldt [mailto:hans.fe...@ericsson.com]
> Sent: 02 May 2014 17:18
> To: Nagendra Kumar; Praveen Malviya; Hans Nordebäck
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: RE: [devel] [PATCH 4 of 7] amfd: add SU
> -Original Message-
> From: Nagendra Kumar [mailto:nagendr...@oracle.com]
> Sent: den 2 maj 2014 12:31
> To: Hans Feldt; Praveen Malviya; Hans Nordebäck
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [devel] [PATCH 4 of 7] amfd: add SU constr/destr [#713]
1. Can we move all the initialization in default constructor and fill dn
name after words.
2. Other pointers are not necessary to initialize, any specific reason for
doing it?
Thanks
-Nagu
> -Original Message-
> From: Hans Feldt [mailto:osafde...@gmail.com]
> Sent: 30 April 2
OK I will declare them private for now until we have a common macro for it.
/HansF
On 30 April 2014 13:49, Hans Nordebäck wrote:
> ack, only code review, one comment shouldn't copy and assignment operators
> be disabled? I.e. declare them private, or use google style
>
> DISALLOW_COPY_AND_ASSIGN(
ack, only code review, one comment shouldn't copy and assignment
operators be disabled? I.e. declare them private, or use google style
DISALLOW_COPY_AND_ASSIGN(AVD_SU);
/Regards HansN
On 04/30/14 07:01, Hans Feldt wrote:
> osaf/services/saf/amf/amfd/include/su.h | 17 +--
> osaf/service
osaf/services/saf/amf/amfd/include/su.h | 17 +--
osaf/services/saf/amf/amfd/su.cc| 74 +++-
2 files changed, 37 insertions(+), 54 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/su.h
b/osaf/services/saf/amf/amfd/include/su.h
--- a/osaf/ser