[devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA v1 [#1574]

2016-08-02 Thread Hoang Vo
osaf/libs/agents/saf/cpa/cpa_api.c | 30 -- osaf/libs/agents/saf/cpa/cpa_mds.c | 6 - osaf/libs/common/cpsv/cpsv_evt.c| 1 + osaf/services/saf/cpsv/cpd/cpd_evt.c| 10 ++-- osaf/services/saf/cpsv/cpd/cpd_mds.c| 2 + osaf/services/saf

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA v1 [#1574]

2016-07-05 Thread A V Mahesh
Hi Hoang, -case CPD_EVT_ND2D_CKPT_UNLINK: +case CPD_EVT_ND2D_CKPT_UNLINK_2: -send_evt.info.cpnd.type = CPND_EVT_D2ND_CKPT_CREATE; +send_evt.info.cpnd.type = CPND_EVT_D2ND_CKPT_CREATE_2; Is this changes tested with in-service upgrade ? case like old ND and new ND , New Director

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA v1 [#1574]

2016-07-28 Thread A V Mahesh
Hi Hoang, I just started reviewing please share following : I hope this Long DN should support In-service upgrade , if so, please share the test case that you run , it will help me in reviewing and in test uncovered use/test cases. -AVM On 7/21/2016 3:04 PM, Hoang Vo wrote: > osaf/libs/

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA v1 [#1574]

2016-07-28 Thread Vo Minh Hoang
Dear Mahesh, We do not have specific test case and environment for in-service update. So my test work is based on osaftest cases. I tested with old d - new nd and new d - old nd cases. There are failed test cases but after investigating, they are intensional when old one cannot recognize new mess

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA v1 [#1574]

2016-07-28 Thread A V Mahesh
Hi , I have proved some code related minor comment in 4 of 8 , 6 of 8 & 8 of 8 , please address them also in new patch(s). Reading testing : On 7/29/2016 7:49 AM, Vo Minh Hoang wrote: > We do not have specific test case and environment for in-service update. > So my test work is based on osaf

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA v1 [#1574]

2016-07-28 Thread A V Mahesh
Hi Hoang, Minor comment -AVM On 7/21/2016 3:04 PM, Hoang Vo wrote: > osaf/libs/agents/saf/cpa/cpa_api.c | 12 +--- > osaf/libs/agents/saf/cpa/cpa_mds.c | 2 +- > osaf/libs/common/cpsv/cpsv_evt.c| 1 + > osaf/services/saf/cpsv/cpd/cpd_evt.c| 10 +++---

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA v1 [#1574]

2016-07-28 Thread Vo Minh Hoang
Dear Mahesh, Thank you very much for your comment. I start working on it from now. Sincerely, Hoang -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Friday, July 29, 2016 1:27 PM To: Vo Minh Hoang Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 6 o

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA v1 [#1574]

2016-08-02 Thread Vo Minh Hoang
Dear Mahesh, I have just submitted the V3 patch fixing source code following your comment. I also update readme file that is attached to this email. Please tell me if you have any further inquiry. Thank you and best regards, Hoang -Original Message- From: A V Mahesh [mailto:mahesh.va...@

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA v1 [#1574]

2016-08-10 Thread A V Mahesh
Hi Hoan, I hope the patch published On 8/2/2016 2:14 PM is the New version V2 If you are sending new version please update V1 to V2 , form next time on-words -AVM On 8/2/2016 2:17 PM, Vo Minh Hoang wrote: > Dear Mahesh, > > I have just submitted the V3 patch fixing source code following y

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA v1 [#1574]

2016-08-11 Thread A V Mahesh
Hi Hoang, We don't required any new event like CPND_EVT_D2ND_CKPT_CREATE_2 even though NEW CPND might might be sending event to OLD CPD. In general Opensaf rule is that any newly introduce enhancement/feature functionality can be used once Cluster is completely upgraded to new version.So while

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA v1 [#1574]

2016-08-14 Thread Vo Minh Hoang
Dear Mahesh, Thank you very much for your review. I would like to answer to your concern. The solution of adding new messages instead of updating old one mostly because Long DN function has been working in current system (other modules already support long DN). So if we do not handle this, there

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA v1 [#1574]

2016-08-15 Thread A V Mahesh
Hi Hoang, Please find my responses as [AVM]. -AVM On 8/15/2016 8:16 AM, Vo Minh Hoang wrote: > Dear Mahesh, > > Thank you very much for your review. > I would like to answer to your concern. > > The solution of adding new messages instead of updating old one mostly > because Long DN function has

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA v1 [#1574]

2016-08-15 Thread Vo Minh Hoang
Dear Mahesh, Thank you very much for your clarifying. When other service did also, I will update and provide patch that don't use new messages. Thank you and best regards, Hoang -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Tuesday, August 16, 2016 11:29 AM