Re: [devel] [PATCH 1/1] ckptnd: fix crash during checkpoint open timeout with large sections [#1510]

2017-10-22 Thread Vo Minh Hoang
Hi Alex, Sorry I got confuse so the comment is not clear, and maybe is wrong. I try to rewrite it. - Do we really need to add a flag variable for tracking node_added? If we implement cpnd_ckpt_node_del() before ckpt_shm_node_free_error and after agent_rsp2 with new goto mark that might

Re: [devel] [PATCH 1/1] ckptnd: fix crash during checkpoint open timeout with large sections [#1510]

2017-10-20 Thread Alex Jones
signature.asc Description: OpenPGP digital signature -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org!

Re: [devel] [PATCH 1/1] ckptnd: fix crash during checkpoint open timeout with large sections [#1510]

2017-10-20 Thread Vo Minh Hoang
Dear Alex, I got confuse with this path as following: >> sync from the active can timeout with errorcode SA_AIS_ERR_TRY_AGAIN Does that mean out_evt->info.cpnd.error == SA_AIS_ERR_TRY_AGAIN? Your current cpnd_ckpt_node_del() is added in ckpt_node_free_error. If above is true, please consider