tests/immsv/common/immtest.c | 60 +-
tests/immsv/implementer/Makefile.am|1 +
tests/immsv/implementer/applier.c | 24 +-
tests/immsv/implementer/test_cleanup.c | 38 +-
osaf/tools/safimm/src/immutil.c | 15 ---
samples/immsv/immutils/immutil.c | 15 ---
2 files changed, 16 insertions(+), 14 deletions(-)
When there are more CCBs in CcbUtilCcbData, the first call of
ccbutil_deleteCcbData() free all object names from active CCBs.
The
n
Other n
Comments (indicate scope for each y above):
-
changeset a6b55619d62790609711fe8d7e77d178bbeecf16
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Mon, 25 Aug 2014 15:16:04 +0200
immtools: fix
osaf/tools/safimm/immcfg/imm_cfg.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
The patch enables using osaf_extended_name_* functions in the correct way
before the first saImmOmInitialize() is called.
diff --git a/osaf/tools/safimm/immcfg/imm_cfg.c
. It will be weird it the application does not support long DN,
and successfully use imm tools on objects with long DN.
Best regards,
Zoran
-Original Message-
From: Anders Widell
Sent: den 26 augusti 2014 13:13
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
n
Other n
Comments (indicate scope for each y above):
-
changeset cf9ff95ba297c121a5a46f4ebde4f5294cf5a284
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Tue, 26 Aug 2014 15:58:56 +0200
imm: fix loading
Agree to you.
For the new option, we need a new ticket. We cannot fix it in this ticket.
Regards,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: den 26 augusti 2014 15:38
To: Zoran Milinkovic; Anders Widell; Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE
Good work.
Ack from me.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 27 augusti 2014 14:14
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm:corrected
n
Other n
Comments (indicate scope for each y above):
-
changeset 08cb8e6d89b75d279eb3746be1091db2fedcf91c
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Fri, 29 Aug 2014 11:26:23 +0200
imm: fix
osaf/services/saf/immsv/immnd/ImmModel.cc | 86 ++
1 files changed, 63 insertions(+), 23 deletions(-)
The patch fix loading SaNameT attributes with long DNs before
opensafImm=opensafImm,safApp=safImmService is created.
diff --git
I will add changes from comments when I push the code.
Find my comment in the code.
-Original Message-
From: Anders Björnerstedt
Sent: den 2 september 2014 14:54
To: Zoran Milinkovic
Cc: reddy.neelaka...@oracle.com; opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1
with
latest changeset)
The below fix may not be required.
/Neel.
On Monday 25 August 2014 07:14 PM, Zoran Milinkovic wrote:
osaf/tools/safimm/immcfg/imm_cfg.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
The patch enables using osaf_extended_name_* functions in the correct way
Other n
Comments (indicate scope for each y above):
-
changeset 3273d38052f92c7b947cfb9450042fc8856ac8c7
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Wed, 03 Sep 2014 15:21:21 +0200
immtools: support long DN
osaf/tools/safimm/immadm/imm_admin.c| 7 +++
osaf/tools/safimm/immcfg/imm_cfg.c | 6 ++
osaf/tools/safimm/immdump/imm_dumper.cc | 8
osaf/tools/safimm/immfind/imm_find.c| 6 ++
osaf/tools/safimm/immlist/imm_list.c| 7 +++
5 files changed, 34
Reviewed, but didn't test.
Ack from me.
Regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 3 september 2014 16:35
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1
'MDS_DEST'
make[6]: *** [libmds_la-mds_c_api.lo] Error 1
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 3 september 2014 16:25
To: Zoran Milinkovic; mahesh.va...@oracle.com; ramesh.bet...@oracle.com
Cc: opensaf-devel
With patch #1041, OpenSAF is compiled on 32-bit linux.
Ack from me.
Best regards,
Zoran
-Original Message-
From: Zoran Milinkovic
Sent: den 3 september 2014 17:02
To: 'reddy.neelaka...@oracle.com'; mahesh.va...@oracle.com;
ramesh.bet...@oracle.com
Cc: opensaf-devel
Reviewed and compiled.
Ack from me.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 3 september 2014 16:41
To: Zoran Milinkovic; mahesh.va...@oracle.com; mathi.naic...@oracle.com
Cc: opensaf-devel
Reviewed, but didn't test.
Ack from me.
Best regards,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: den 4 september 2014 12:02
To: reddy.neelaka...@oracle.com; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] IMM: PBE exits on errors where
.
With this small change, unnecessary lock/unlock and table lookup can be skipped
if the first callback is NULL.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 4 september 2014 15:19
To: Anders Björnerstedt; Zoran Milinkovic
On every 10 objects, the same message will be written twice to the log.
Ack when the comment is fixed.
Best regards,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: den 8 september 2014 11:28
To: reddy.neelaka...@oracle.com; Zoran Milinkovic
Cc: opensaf-devel
Good catch.
Ack from me.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 9 september 2014 10:06
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] immtools:corrected variable
n
Other n
Comments (indicate scope for each y above):
-
changeset 21faee54205e3102717885d2a689ba8c359d949f
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Tue, 09 Sep 2014 13:30:56 +0200
imm: add
osaf/services/saf/immsv/immnd/ImmModel.cc | 22 ++
1 files changed, 22 insertions(+), 0 deletions(-)
Validation that the value of accessControlMode is not out of range.
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
b/osaf/services/saf/immsv/immnd/ImmModel.cc
---
Hi,
If i == 1023, then you end up in else branch, and you have the same problem
again (i + 1 == 1024)
+} else {
+/* Add line feed if not there already */
+if (log_string[i - 1] != '\n') {
+log_string[i] = '\n';
+log_string[i + 1] = '\0';
+
Ack from me.
Best regards,
Zoran
-Original Message-
From: Anders Bjornerstedt [mailto:anders.bjornerst...@ericsson.com]
Sent: den 16 september 2014 09:23
To: reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1 of 1] imm: Compare err instead of
Ack from me.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 15 september 2014 12:09
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: Return
Ack from me.
Regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 17 september 2014 14:06
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: Return TRY_AGAIN only
Ack from me.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 18 september 2014 14:38
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm:corrected
Ack from me.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 19 september 2014 09:54
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: check the end ccb
a problem.
/AndersBj
-Original Message-
From: Anders Björnerstedt [mailto:anders.bjornerst...@ericsson.com]
Sent: den 19 september 2014 09:48
To: reddy.neelaka...@oracle.com; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] imm: check the end ccb
Ack from me.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 19 september 2014 14:35
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm:corrected missing
n
Other n
Comments (indicate scope for each y above):
-
changeset 620a92a96569d60f5a73393e34b6512e77993a61
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Fri, 19 Sep 2014 14:35:43 +0200
immutils: fix long DN
Ack from me.
Best regards,
Zoran
-Original Message-
From: Anders Bjornerstedt [mailto:anders.bjornerst...@ericsson.com]
Sent: den 19 september 2014 14:36
To: reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1 of 1] IMM: Extend osafassert check
Ack from me.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 19 september 2014 15:00
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm:Removed the erase
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 280a0807bf21657e0c44d0189b93f6bc9160f781
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Mon, 22 Sep 2014 11:13:33
osaf/tools/safimm/immadm/imm_admin.c | 23 +--
1 files changed, 17 insertions(+), 6 deletions(-)
The patch does not allow to set more than one admin owner name.
diff --git a/osaf/tools/safimm/immadm/imm_admin.c
b/osaf/tools/safimm/immadm/imm_admin.c
---
Ack from me.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 22 september 2014 13:30
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm:fix memory leaks
...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 22 september 2014 13:45
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm:checking of mImplementer is corrected in
setImplementer[#1084]
osaf/services/saf/immsv/immnd
: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 22 september 2014 14:25
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm:checking of mImplementer is corrected in
setImplementer[#1084] V2
osaf/services/saf/immsv/immnd
n
Other n
Comments (indicate scope for each y above):
-
changeset cc6b206093ae9052166cd6c02084b624d0cb113f
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Mon, 29 Sep 2014 15:38:28 +0200
imm: add missing
osaf/libs/agents/saf/imma/imma_om_api.c | 22 +++---
1 files changed, 15 insertions(+), 7 deletions(-)
Add missing check for the case that root name length is great than 0, and root
name value length is 0.
diff --git a/osaf/libs/agents/saf/imma/imma_om_api.c
osaf/libs/agents/saf/imma/imma_om_api.c | 24 ++--
1 files changed, 18 insertions(+), 6 deletions(-)
Add missing check for the case that root name length is great than 0, and root
name value length is 0.
Fix validation of root name.
diff --git
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset ecbd00b554f3a2d0edadf48271cf6952fa436e94
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Mon, 29 Sep 2014 15:37:46 +0200
Yes, it was a mistake.
Review is for opensaf-4.5.x and default(4.6)
Regards,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: den 29 september 2014 15:51
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 0 of 1] Review Request for imm: add
mds_dest should be traced in hexadecimal format.
Ack when the format is changed.
No need for another review.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 1 oktober 2014 10:44
To: Zoran Milinkovic; mathi.naic
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 070d82cdd756ebcd878b00b94615e4c175823cb6
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Wed, 01 Oct 2014 17:18:58 +0200
osaf/services/saf/immsv/config/immnd.conf | 3 ---
osaf/services/saf/immsv/immnd/ImmModel.cc | 17 -
osaf/services/saf/immsv/immnd/immnd_main.c | 5 +
3 files changed, 13 insertions(+), 12 deletions(-)
Removed SA_ENABLE_EXTENDED_NAMES from immnd.conf, and set in immnd
n
Other n
Comments (indicate scope for each y above):
-
changeset f0f43c661c1bf68fec076e98e65678ceb7a5a2c0
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Thu, 02 Oct 2014 22:46:56 +0200
imm: set
osaf/services/saf/immsv/immloadd/imm_loader.cc | 66 +
1 files changed, 54 insertions(+), 12 deletions(-)
DNs and attribute names could be partially loaded due to buffer size in libxml.
The patch merges character fragments.
diff --git
n
Other n
Comments (indicate scope for each y above):
-
changeset 565d7ad5ba29e0b31e7933fd879d3a93a4c1e449
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Fri, 03 Oct 2014 01:21:13 +0200
imm
n
Other n
Comments (indicate scope for each y above):
-
changeset 8db8c196c0e5f5d45241c2b8cc3d0a9f8d19e0ac
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Fri, 03 Oct 2014 02:22:10 +0200
imm: fix loading
osaf/services/saf/immsv/immloadd/imm_loader.cc | 69 -
1 files changed, 55 insertions(+), 14 deletions(-)
DNs and attribute names could be partially loaded due to buffer size in libxml.
The patch merges character fragments.
diff --git
osaf/services/saf/immsv/immloadd/imm_loader.cc | 69 -
1 files changed, 55 insertions(+), 14 deletions(-)
DNs and attribute names could be partially loaded due to buffer size in libxml.
The patch merges character fragments.
diff --git
osaf/tools/safimm/immcfg/imm_import.cc | 52 ++---
1 files changed, 41 insertions(+), 11 deletions(-)
DNs and attribute names could be partially loaded due to buffer size in libxml.
The patch merges character fragments.
diff --git
n
Other n
Comments (indicate scope for each y above):
-
changeset 7630f2349a8340236fd09ef00b1ce74216ce4c9f
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Fri, 03 Oct 2014 02:24:12 +0200
imm: fix loading
:16
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] immtools:exit immcfg if classname is not present while
loading objects[#1168]
osaf/tools/safimm/immcfg/imm_import.cc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/osaf/tools/safimm
...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 14 oktober 2014 09:08
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] immtools:exit immcfg if classname is not present while
loading objects[#1168] v2
osaf/tools/safimm/immcfg/imm_import.cc | 6 +-
1
Reviewed and tested the patch.
Ack from me.
Regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 16 oktober 2014 13:35
To: Zoran Milinkovic; Anders Björnerstedt
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1
Samples n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 19c8c6450e4f1c182b497a2a80967fc9852badc9
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Thu, 23 Oct 2014
osaf/libs/agents/saf/imma/imma_om_api.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
The patch solves a bug in admin operation when return parameters contain valid
extended name.
diff --git a/osaf/libs/agents/saf/imma/imma_om_api.c
b/osaf/libs/agents/saf/imma/imma_om_api.c
---
n
Other n
Comments (indicate scope for each y above):
-
changeset c8f142f8dbcfe47dcf008c6491c5b7ad564bfb8f
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Wed, 29 Oct 2014 14:55:11 +0100
immtools: support
osaf/libs/common/immsv/immpbe_dump.cc | 19 +-
osaf/libs/common/immsv/include/immpbe_dump.hh | 2 +
osaf/tools/safimm/immdump/imm_dumper.cc | 87 +-
osaf/tools/safimm/immdump/imm_dumper.hh | 3 +-
osaf/tools/safimm/immdump/imm_xmlw_dump.cc
n
Other n
Comments (indicate scope for each y above):
-
changeset 63f99da245eaa919aac787f789e030afc29a7f86
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Thu, 30 Oct 2014 11:57:09 +0100
immtools: remove
osaf/tools/safimm/immadm/imm_admin.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Remove unnecessary output when admin owner is set in immadm
diff --git a/osaf/tools/safimm/immadm/imm_admin.c
b/osaf/tools/safimm/immadm/imm_admin.c
--- a/osaf/tools/safimm/immadm/imm_admin.c
+++
osaf/services/saf/immsv/immnd/ImmModel.cc | 67 +-
1 files changed, 46 insertions(+), 21 deletions(-)
For augmented CCB opreations (create/modify/delete), OI timeout is removed from
CCB.
When OI callback responds, OI timeout starts to count again for CCB.
diff
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset efca97f156938361426464c42476bb091e97b2c2
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Thu, 30 Oct 2014 15:58:19 +0100
imm
samples/immsv/immutils/immutil.c | 55 ++-
1 files changed, 37 insertions(+), 18 deletions(-)
Fix crashing problem when bad SaNameT value is used in immutils.
diff --git a/samples/immsv/immutils/immutil.c b/samples/immsv/immutils/immutil.c
---
n
Other n
Comments (indicate scope for each y above):
-
changeset 502511f470226440679c0e9ddd30d670d98e17d1
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Wed, 05 Nov 2014 11:27:49 +0100
immutils: fix long DN
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 8a9ece4f5cf4d3f1268ef12966eb1b901b7d5dea
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Mon, 10 Nov 2014 14:03:36
osaf/services/saf/immsv/immnd/ImmModel.cc | 9 ++---
1 files changed, 2 insertions(+), 7 deletions(-)
When CCB agumentation is closing, CCB timeout is removed.
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
b/osaf/services/saf/immsv/immnd/ImmModel.cc
---
Reviewed the patch.
Ack from me.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 12 november 2014 10:14
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] immtools: Initialization
osaf/libs/agents/saf/imma/imma_om_api.c | 21 +++--
osaf/libs/common/immsv/immsv_evt.c | 22 ++
osaf/libs/common/immsv/include/immsv_evt_model.h | 2 +
osaf/services/saf/immsv/immnd/ImmModel.cc| 36 +++-
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 2b6be4f2eaedd2f0131a2d48bcd3d343cfc4d905
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Mon, 17 Nov 2014 09:36
Find my comment inline.
Ack from me when the comment is fixed.
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 17 november 2014 10:08
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 2 of 2] immtools: Add --ccb-validate
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 8f15445f057048a6496713488b6d8cf1a578f255
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Tue, 18 Nov 2014 16:50:46 +0100
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset b67a51819f2a2c66c9b41fb0e11d3b96b26ebbff
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Thu, 20 Nov 2014 11:52:35 +0100
osaf/libs/agents/saf/imma/imma_proc.c | 30 +-
1 files changed, 29 insertions(+), 1 deletions(-)
The patch checks SaNameT attribute for extended names if extended names are not
enabled.
If any SaNameT attribute contains long DN, SA_AIS_ERR_NAME_TOO_LONG will be
osaf/libs/agents/saf/imma/imma_om_api.c | 21 +-
osaf/libs/common/immsv/immsv_evt.c | 22 +--
osaf/libs/common/immsv/include/immsv_evt_model.h | 2 +
osaf/services/saf/immsv/immnd/ImmModel.cc| 70 +++-
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 3e412a9fc4fd44dcd38ea8bf08080ccfbc1df66f
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Thu, 20 Nov 2014 16:12
osaf/services/saf/immsv/immnd/ImmModel.cc | 57 +++---
1 files changed, 44 insertions(+), 13 deletions(-)
In the first patch, a check for multivalue attributes was missed. This patch
adds that checks.
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 87301a36ef17883289c91287d2dbacf148d906b3
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Fri, 21 Nov 2014 18:17:02
Reviewed and tested.
Ack from me.
Best regards,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 12 december 2014 13:39
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 1] Review Request for immtools: Support
osaf/services/saf/immsv/immloadd/imm_loader.cc | 11 +-
osaf/services/saf/immsv/immloadd/imm_pbe_load.cc |2 +-
osaf/services/saf/immsv/immnd/ImmModel.cc | 546 +---
osaf/services/saf/immsv/immnd/ImmModel.hh |1 +
osaf/libs/agents/saf/imma/imma_cb.h |3 +
osaf/libs/agents/saf/imma/imma_def.h |2 +-
osaf/libs/agents/saf/imma/imma_oi_api.c | 324 +++--
osaf/libs/agents/saf/imma/imma_om_api.c | 731 ++
tests/immsv/common/immtest.c | 4 +-
tests/immsv/implementer/Makefile.am | 1 +
tests/immsv/implementer/test_cleanup.c| 3 +
tests/immsv/implementer/test_saImmOiClassImplementerSet.c | 2 -
osaf/tools/safimm/immadm/imm_admin.c | 2 +-
osaf/tools/safimm/immcfg/imm_cfg.c | 2 +-
osaf/tools/safimm/immcfg/imm_import.cc | 7 +--
osaf/tools/safimm/immdump/imm_xmlw_dump.cc | 9 +
osaf/tools/safimm/immfind/imm_find.c | 2 +-
Ack from me.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 22 januari 2015 07:47
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm : Added IMM_ERROR
osaf/services/saf/immsv/immloadd/imm_loader.cc | 11 +-
osaf/services/saf/immsv/immloadd/imm_pbe_load.cc |2 +-
osaf/services/saf/immsv/immnd/ImmModel.cc | 500 +---
osaf/services/saf/immsv/immnd/immnd_evt.c | 21 +-
n
Other n
Comments (indicate scope for each y above):
-
changeset a82235a28c7687d7e131283a084c972cff457a05
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Tue, 10 Feb 2015 17:51:25 +0100
imm: add new API
tests/immsv/common/immtest.c | 4 +-
tests/immsv/implementer/Makefile.am | 1 +
tests/immsv/implementer/test_cleanup.c| 3 +
tests/immsv/implementer/test_saImmOiClassImplementerSet.c | 2 -
opensaf.spec.in |2 +
osaf/libs/agents/saf/imma/imma_cb.h |3 +
osaf/libs/agents/saf/imma/imma_def.h |2 +-
osaf/libs/agents/saf/imma/imma_oi_api.c | 324 +++--
osaf/libs/agents/saf/imma/imma_om_api.c |
osaf/tools/safimm/immadm/imm_admin.c | 2 +-
osaf/tools/safimm/immcfg/imm_cfg.c | 2 +-
osaf/tools/safimm/immcfg/imm_import.cc | 7 +--
osaf/tools/safimm/immdump/imm_xmlw_dump.cc | 9 +
osaf/tools/safimm/immfind/imm_find.c | 2 +-
Reviewed and built code with and without --enable-imm-pbe flag.
Ack from me.
Best regards,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 8 januari 2015 06:55
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 1
osaf/services/saf/immsv/immnd/immnd_evt.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
Fix memory leak in search init
diff --git a/osaf/services/saf/immsv/immnd/immnd_evt.c
b/osaf/services/saf/immsv/immnd/immnd_evt.c
--- a/osaf/services/saf/immsv/immnd/immnd_evt.c
+++
tests/immsv/common/immtest.c | 4 +-
tests/immsv/implementer/Makefile.am | 1 +
tests/immsv/implementer/test_cleanup.c| 3 +
tests/immsv/implementer/test_saImmOiClassImplementerSet.c | 2 -
y
Other n
Comments (indicate scope for each y above):
-
changeset 57bcdde2358f69b5696fdd7002e3f1decd8da69d
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Tue, 10 Mar 2015 16:37:08 +0100
imm: add new API
Hi Anders,
I'll implement your comments before pushing the code.
Changes that you marked as 'spurious' are mostly done by a tool, and only
indentation is affected.
Thanks,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: Wednesday, March 11, 2015 1:31 PM
To: Zoran Milinkovic
Hi Anders,
I'll add description of the flag before pushing the code.
Thanks,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: Wednesday, March 11, 2015 1:30 PM
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH
osaf/tools/safimm/immadm/imm_admin.c | 2 +-
osaf/tools/safimm/immcfg/imm_cfg.c | 2 +-
osaf/tools/safimm/immcfg/imm_import.cc | 7 +--
osaf/tools/safimm/immdump/imm_xmlw_dump.cc | 9 +
osaf/tools/safimm/immfind/imm_find.c | 2 +-
101 - 200 of 678 matches
Mail list logo
