- **status**: review --> fixed
- **Comment**:
changeset: 8592:f13798019501
tag: tip
user:Nagendra Kumar
date:Tue Feb 21 10:01:48 2017 +0530
summary: amfd: return TRY_AGAIN on rollback of shutdown admin op [#2133]
[staging:f13798]
- **status**: accepted --> review
- **Comment**:
Sent patch for review with the above implementation.
---
** [tickets:#2133] AMF: Rollback admin shutdown/lock SI operation if node
failover**
**Status:** review
**Milestone:** 5.2.FC
**Created:** Thu Oct 20, 2016 06:49 PM UTC by Minh Hon Chau
Hi Minh,
I also wouldn’t prefer to rollback but because of internal
implementation, I am just reusing the code. I am preferring return code as
TRY_AGAIN because the error has occurred and the operation can’t be completed.
Thanks
-Nagu
---
** [tickets:#2133] AMF: Rollback
- **Type**: defect --> enhancement
- **Comment**:
Changing to enhancement as it changes return types of few admin operation
mentioned above.
---
** [tickets:#2133] AMF: Rollback admin shutdown/lock SI operation if node
failover**
**Status:** accepted
**Milestone:** 5.2.FC
**Created:** Thu
Any comment ? I am preparing the patch with TRY_AGAIN.
---
** [tickets:#2133] AMF: Rollback admin shutdown/lock SI operation if node
failover**
**Status:** accepted
**Milestone:** 5.2.FC
**Created:** Thu Oct 20, 2016 06:49 PM UTC by Minh Hon Chau
**Last Updated:** Mon Jan 30, 2017 06:48 AM
>>I think it's good idea that we return other codes (TIMEOUT,...?) in case
>>error escalation that rollback the shutdown command.
I think it is better to return TRY_AGAIN as it gives some margin for Error
occured in Specs.
"SA_AIS_ERR_TRY_AGAIN - The service cannot be provided at this time. The
I will provied fix of 2N red model for 5.2 release. The fix would be to return
TIMEOUT for failure of admin shutdown cases when shutdown admin op gets
reverted and admin state is rolled back to Unlocked.
---
** [tickets:#2133] AMF: Rollback admin shutdown/lock SI operation if node
failover**
>>Comparing to your findings, is there something we have to do with "single SI
>>assignment, the admin state is locked." for su f/o and node f/o?
No, I think, if it is single SI assignment, we can return Success and mark
admin state as Locked.
>>Another question, do you know use case's
- **status**: unassigned --> accepted
- **assigned_to**: Nagendra Kumar
- **Milestone**: future --> 5.2.FC
---
** [tickets:#2133] AMF: Rollback admin shutdown/lock SI operation if node
failover**
**Status:** accepted
**Milestone:** 5.2.FC
**Created:** Thu Oct 20, 2016 06:49 PM UTC by Minh
Hi Nagu,
The section 3.6.2 in Compliance Table in AMF PR says:
In 2N model, deviations related to shutdown operation on SI:
1) During shutdown operation on SI if component faults and it leads to
component-failover, sufailover or nodefailover, then shutdown operation will
not be completed and
I will check the admin op return code and will try to fix them.
---
** [tickets:#2133] AMF: Rollback admin shutdown/lock SI operation if node
failover**
**Status:** unassigned
**Milestone:** future
**Created:** Thu Oct 20, 2016 06:49 PM UTC by Minh Hon Chau
**Last Updated:** Wed Jan 18, 2017
- **summary**: AMF: Rollback admin shutdown SI operation if node failover -->
AMF: Rollback admin shutdown/lock SI operation if node failover
- **Type**: discussion --> defect
- **Milestone**: 5.2.FC --> future
---
** [tickets:#2133] AMF: Rollback admin shutdown/lock SI operation if node
12 matches
Mail list logo