That would work. As long as it is possible to rollback the campaign it
is fine.
On 10/20/2017 03:18 PM, Alex Jones wrote:
>
> I understand the intention. It makes sense.
>
> One of the other solutions I had considered is to put a check at the
> beginning of SmfCampaign::initExecution(). If the campaign state is
> EXECUTION_COMPLETED, then just return. What is the point of
> reexecuting a campaign that already completed?
>
> Are you OK with that?
>
> ------------------------------------------------------------------------
>
> *[tickets:#2648] <https://sourceforge.net/p/opensaf/tickets/2648/>
> smf: smfd crashes after cluster reboot when campaign is in
> ExecutionCompleted*
>
> *Status:* review
> *Milestone:* 5.17.10
> *Created:* Thu Oct 19, 2017 06:45 PM UTC by Alex Jones
> *Last Updated:* Fri Oct 20, 2017 10:04 AM UTC
> *Owner:* Alex Jones
>
> smfd crashes in updateImmAttr because it returns NO_RESOURCES. Here is
> how to reproduce:
>
> 1. enable PBE, and make sure the "disable" flag is set in
> OpenSafSmfConfig
> 2. execute an upgrade campaign, and let it go to "execution
> completed", but don't commit it
> 3. reboot the entire cluster
> 4. only allow 1 system controller to come up
> 5. smfd will attempt to re-execute the campaign
> 6. any writes to IMM (like setting an error because the campaign file
> can't be found) will fail with NO_RESOURCES and smfd will assert
> and crash
>
> The reason for the assert and crash is because PBE has not been turned
> off by smfd before the campaign has been inititialized.
>
> ------------------------------------------------------------------------
>
> Sent from sourceforge.net because you indicated interest in
> https://sourceforge.net/p/opensaf/tickets/2648/
>
> To unsubscribe from further messages, please visit
> https://sourceforge.net/auth/subscriptions/
>
---
** [tickets:#2648] smf: smfd crashes after cluster reboot when campaign is in
ExecutionCompleted**
**Status:** review
**Milestone:** 5.17.10
**Created:** Thu Oct 19, 2017 06:45 PM UTC by Alex Jones
**Last Updated:** Fri Oct 20, 2017 01:18 PM UTC
**Owner:** Alex Jones
smfd crashes in updateImmAttr because it returns NO_RESOURCES. Here is how to
reproduce:
1. enable PBE, and make sure the "disable" flag is set in OpenSafSmfConfig
2. execute an upgrade campaign, and let it go to "execution completed", but
don't commit it
3. reboot the entire cluster
4. only allow 1 system controller to come up
5. smfd will attempt to re-execute the campaign
6. any writes to IMM (like setting an error because the campaign file can't be
found) will fail with NO_RESOURCES and smfd will assert and crash
The reason for the assert and crash is because PBE has not been turned off by
smfd before the campaign has been inititialized.
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
