Re: [opensc-devel] Embended openSC and environment variable

2006-06-26 Thread Peter Stuge
On Mon, Jun 26, 2006 at 10:17:07PM +0200, Andreas Jellinghaus wrote: > Peter Stuge wrote: > >Looks good. Perhaps there could be a compiled-in default also for > >WIN32, that way the code would be slightly cleaner. > > The compiled in default is always wrong, as some people install on > C, some on

Re: [opensc-devel] Embended openSC and environment variable

2006-06-26 Thread Andreas Jellinghaus
Peter Stuge wrote: Looks good. Perhaps there could be a compiled-in default also for WIN32, that way the code would be slightly cleaner. The compiled in default is always wrong, as some people install on C, some on D, some with german windows "Programme" some with english "Programs" and so on.

Re: [opensc-devel] debug code changes

2006-06-26 Thread Andreas Jellinghaus
Nils Larsch wrote: > Andreas Jellinghaus wrote: >>> (note: I think it would be better to hardcode the debug level in the >>> macro definition of SC_TEST_RET() (and SC_FUNC_CALLED() + SC_FUNC_RETURN()) >>> instead of adding an additional parameter to the macro). > sorry but I don't understand wi

Re: [opensc-devel] debug code changes

2006-06-26 Thread Peter Stuge
On Mon, Jun 26, 2006 at 02:36:56PM +0200, Ludovic Rousseau wrote: > (tested with gcc 4.0.1 under Mac OS X 10.4) Works fine with gcc 3.4.5 on Gentoo as well. //Peter ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-p

Re: [opensc-devel] Embended openSC and environment variable

2006-06-26 Thread Peter Stuge
On Mon, Jun 26, 2006 at 09:00:11PM +0200, Peter Stuge wrote: > On Mon, Jun 26, 2006 at 09:34:35AM +0200, Andreas Jellinghaus wrote: > > diff -udrNPp --exclude=.svn opensc.orig/src/libopensc/ctx.c > > opensc/src/libopensc/ctx.c > > --- opensc.orig/src/libopensc/ctx.c 2006-06-08 09:08:52.0 +

Re: [opensc-devel] Embended openSC and environment variable

2006-06-26 Thread Peter Stuge
On Mon, Jun 26, 2006 at 09:34:35AM +0200, Andreas Jellinghaus wrote: > diff -udrNPp --exclude=.svn opensc.orig/src/libopensc/ctx.c > opensc/src/libopensc/ctx.c > --- opensc.orig/src/libopensc/ctx.c 2006-06-08 09:08:52.0 +0200 > +++ opensc/src/libopensc/ctx.c2006-06-26 09:28:32.00

Re: [opensc-devel] debug code changes

2006-06-26 Thread Ludovic Rousseau
On 26/06/06, Andreas Jellinghaus <[EMAIL PROTECTED]> wrote: btw, on enum versus define for the debug level names: with enums, can I assign several enums to the same value? I would want to do that, have several names with the same value (i.e. prepare for more finetuning, even if it isn't used at f

Re: [opensc-devel] Understanding locking

2006-06-26 Thread Nils Larsch
Nils Larsch wrote: Alessandro Premoli wrote: ... Said so, concurrent accesses still don't work as expected. New logs for "open thunderbird -> read encrypted msg -> run pkcs11-tool -I -> try to reopen msg" are available at: http://www.alexdupre.com/pkcs11/opensc-snap-concur-lock.log http://www

Re: [opensc-devel] Understanding locking

2006-06-26 Thread Nils Larsch
Alessandro Premoli wrote: ... Said so, concurrent accesses still don't work as expected. New logs for "open thunderbird -> read encrypted msg -> run pkcs11-tool -I -> try to reopen msg" are available at: http://www.alexdupre.com/pkcs11/opensc-snap-concur-lock.log http://www.alexdupre.com/pkcs1

Re: [opensc-devel] Re: [opensc-commits] svn opensc changed [2968] Added support for MuscleCard applet.

2006-06-26 Thread Nils Larsch
Stef Hoeben wrote: Hi, +void ulong2bebytes(u8 *buf, unsigned long x) +{ +buf[3] = (u8) (x % 256); +x /= 256; +buf[2] = (u8) (x % 256); +x /= 256; +buf[1] = (u8) (x % 256); +buf[0] = (u8) (x / 256); +} I would prefer #define ULONG2BEBYTES(p, x)do {\ (p)[3] = (

Re: [opensc-devel] debug code changes

2006-06-26 Thread Nils Larsch
Andreas Jellinghaus wrote: so the question is also if something like the patch I posted is ok as first step, even if we change the logging later again. actually your patch consist of different parts which perhaps should be treated separately. In particular the harmonization of the debug level

Re: [opensc-devel] Embended openSC and environment variable

2006-06-26 Thread Andreas Jellinghaus
Andreas Jellinghaus wrote: https://www.opensc-project.org/opensc/wiki/UsingOpensc contains the registry keys and the environment setting. so your approach with OPENSC_CONFIG on windows should work fine. if it does not, we have a bug. need to investigate ... On windows the opensc config file

Re: [opensc-devel] debug code changes

2006-06-26 Thread Andreas Jellinghaus
btw, on enum versus define for the debug level names: with enums, can I assign several enums to the same value? I would want to do that, have several names with the same value (i.e. prepare for more finetuning, even if it isn't used at first). Regards, Andreas

Re: [opensc-devel] Embended openSC and environment variable

2006-06-26 Thread Andreas Jellinghaus
https://www.opensc-project.org/opensc/wiki/UsingOpensc contains the registry keys and the environment setting. so your approach with OPENSC_CONFIG on windows should work fine. if it does not, we have a bug. need to investigate ... Andreas ___ opensc-d