Re: [opensc-devel] [opensc-commits] svn opensc changed [3676] reader-pcsc - minor cleanups in reader features

2009-04-03 Thread Alon Bar-Lev
Hello, I've modified this as a user got ERROR_INVALID_FUNCTION and did not know it is safe to ignore it... I don't think there is any reason to alarm users for optional feature determination. However, there are other cases that we do need PCSC_ERROR messages to user, so converting all to debug ma

Re: [opensc-devel] [opensc-commits] svn opensc changed [3676] reader-pcsc - minor cleanups in reader features

2009-04-03 Thread Martin Paljak
On 03.04.2009, at 22:17, webmas...@opensc-project.org wrote: > 3. Do not print error if SCardControl fails. > + sc_debug(reader->ctx, "SCardControl failed", rv); This debug will show a really useless -2x error (after %s is added in the right place?) ... > -

Re: [opensc-devel] [PATCH] openct: HAL FDI update and basic PolicyKit support

2009-04-03 Thread Alon Bar-Lev
Hello, Will you maintain the hal support from now on? Can you please provide a single patch against trunk? A single "svn diff" will do. Thanks! 2009/4/2 Stanislav Brabec : > Attached patches port openct to the latest hal and provide capabilities > for the forthcoming PolicyKit smart card support

Re: [opensc-devel] Question about pkcs11-helper

2009-04-03 Thread Alon Bar-Lev
Hello, The issuers you get are the root certificates. All other certificates are stored in the certs. Two facts you should consider: 1. It is not safe to store root certificates on PKCS#11 token, as anyone, even without authentication can add certificates into the token. 2. Storing the complete c

Re: [opensc-devel] [PATCH] openct: two new USB IDs for openct.conf

2009-04-03 Thread Stanislav Brabec
Alon Bar-Lev wrote: > 2009/4/2 Stanislav Brabec : > > Alon Bar-Lev wrote: > >> Why aren't they detected by the CCID class attribute? > > > > They are detected correctly as "CCID Compatible" even without this > > patch. > > > > So why do we need this? If the list contains only CCID compliant devic