Re: [opensc-devel] [opensc-commits] svn opensc changed[4091] internal.h must be before winreg.h include, and change path for include log.h in cardmod.c

2010-03-09 Thread Andreas Jellinghaus
hmm, why move internal.h? what is in internal.h that changes the winreg.h include? usually it is not internal.h that has some special define, but config.h, and we have that as first include everywhere. so if there is something special in internal.h that I missed, I would like to know :) also it

Re: [opensc-devel] [opensc-commits] svn opensc changed[4091] internal.h must be before winreg.h include, and change path for include log.h in cardmod.c

2010-03-09 Thread François Leblanc
hmm, why move internal.h? what is in internal.h that changes the winreg.h include? Winreg.h depends of definition in windows.h witch is included in internal.h... usually it is not internal.h that has some special define, but config.h, and we have that as first include everywhere. so if there

Re: [opensc-devel] [opensc-commits] svn opensc changed [4091] internal.h must be before winreg.h include , and change path for include log.h in cardmod.c

2010-03-09 Thread Andreas Jellinghaus
Am Dienstag 09 März 2010 13:57:23 schrieb François Leblanc: so we could revert this check, and instead add a /* windows.h required before winreg.h*/ #include windows.h #include winreg.h inside the #ifdef _WIN32 ? looks cleaner to me... Ok for me, I will do the test and make the change

Re: [opensc-devel] [opensc-commits] svn opensc changed[4091] internal.h must be before winreg.h include, and change path for include log.h in cardmod.c

2010-03-09 Thread François Leblanc
so we could revert this check, and instead add a /* windows.h required before winreg.h*/ #include windows.h #include winreg.h inside the #ifdef _WIN32 ? looks cleaner to me... Ok for me, I will do the test and make the change if you are ok? François. smime.p7s Description: S/MIME

Re: [opensc-devel] [opensc-commits] svn opensc changed [4091] internal.h must be before winreg.h include , and change path for include log.h in cardmod.c

2010-03-09 Thread Andreas Jellinghaus
Am Dienstag 09 März 2010 09:21:30 schrieb François Leblanc: hmm, why move internal.h? what is in internal.h that changes the winreg.h include? Winreg.h depends of definition in windows.h witch is included in internal.h... so we could revert this check, and instead add a /* windows.h