Re: [opensc-devel] Bug#494385: prerm doesn't work if openct isn't running

2008-08-12 Thread Ludovic Rousseau
On Tue, Aug 12, 2008 at 8:59 AM, Eric Dorland <[EMAIL PROTECTED]> wrote: > * Ludovic Rousseau ([EMAIL PROTECTED]) wrote: >> Maybe a better solution is to NOT return an error code in case >> "$DAEMON shutdown" fails because no status file is found. >> Than patch is simple: >> Index: src/tools/openct

Re: [opensc-devel] Bug#494385: prerm doesn't work if openct isn't running

2008-08-11 Thread Eric Dorland
* Ludovic Rousseau ([EMAIL PROTECTED]) wrote: > On Mon, Aug 11, 2008 at 2:14 PM, Alon Bar-Lev <[EMAIL PROTECTED]> wrote: > > Thanks! > > Do whatever you think right, but I don't think that searching for a > > specific file is correct, just let the command fail. > > Letting the command fail will al

Re: [opensc-devel] Bug#494385: prerm doesn't work if openct isn't running

2008-08-11 Thread Ludovic Rousseau
On Mon, Aug 11, 2008 at 2:33 PM, Alon Bar-Lev <[EMAIL PROTECTED]> wrote: > "let the command fail" -> I meant ignore... :) > Yes, I agree that this solution is the best one. Commited in revision 1074. Bye -- Dr. Ludovic Rousseau ___ opensc-devel maili

Re: [opensc-devel] Bug#494385: prerm doesn't work if openct isn't running

2008-08-11 Thread Ludovic Rousseau
On Mon, Aug 11, 2008 at 2:14 PM, Alon Bar-Lev <[EMAIL PROTECTED]> wrote: > Thanks! > Do whatever you think right, but I don't think that searching for a > specific file is correct, just let the command fail. Letting the command fail will also make the caller fail. For example when you upgrade a D

Re: [opensc-devel] Bug#494385: prerm doesn't work if openct isn't running

2008-08-11 Thread Alon Bar-Lev
"let the command fail" -> I meant ignore... :) Yes, I agree that this solution is the best one. On 8/11/08, Ludovic Rousseau <[EMAIL PROTECTED]> wrote: > On Mon, Aug 11, 2008 at 2:14 PM, Alon Bar-Lev <[EMAIL PROTECTED]> wrote: > > Thanks! > > Do whatever you think right, but I don't think that s

Re: [opensc-devel] Bug#494385: prerm doesn't work if openct isn't running

2008-08-11 Thread Ludovic Rousseau
On Mon, Aug 11, 2008 at 10:33 AM, Alon Bar-Lev <[EMAIL PROTECTED]> wrote: > I don't understand... the 'echo "."' will always set $? to 0... So how > come the script returns 1? The script uses "set -e" so the interpreting shell will stop on the first error returned by an executed command. If "$DAEM

Re: [opensc-devel] Bug#494385: prerm doesn't work if openct isn't running

2008-08-11 Thread Alon Bar-Lev
I don't understand... the 'echo "."' will always set $? to 0... So how come the script returns 1? On 8/11/08, Ludovic Rousseau <[EMAIL PROTECTED]> wrote: > On Mon, Aug 11, 2008 at 3:58 AM, Eric Dorland <[EMAIL PROTECTED]> wrote: > > Hello list, > > Hello Eric and Wouter, > > > A debian user poi

Re: [opensc-devel] Bug#494385: prerm doesn't work if openct isn't running

2008-08-11 Thread Ludovic Rousseau
On Mon, Aug 11, 2008 at 3:58 AM, Eric Dorland <[EMAIL PROTECTED]> wrote: > Hello list, Hello Eric and Wouter, > A debian user pointed this out bug and it's actually a bug in the init > script exiting with status 1 when you call stop and it's already > stopped. This is against the LSB standard as

Re: [opensc-devel] Bug#494385: prerm doesn't work if openct isn't running

2008-08-10 Thread Eric Dorland
tags 494385 patch thanks Hello list, A debian user pointed this out bug and it's actually a bug in the init script exiting with status 1 when you call stop and it's already stopped. This is against the LSB standard as well (http://refspecs.freestandards.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-gen