Re: [opensc-devel] Changeset 3752: sc_check_apdu and datalen (lc)

2009-10-04 Thread Martin Paljak
On 04.10.2009, at 14:23, Aleksey Samsonov wrote: > I think, here should be SC_APDU_CASE_1 and then SC_PROTO_T0, but if > SC_PROTO_RAW then this is the task to handle in card reader driver > (OpenCT). I think we should wait for Emanuele's comment/test. I'll revert it until that time (there are

Re: [opensc-devel] Changeset 3752: sc_check_apdu and datalen (lc)

2009-10-04 Thread Aleksey Samsonov
Hello, Martin Paljak wrote: > > On 03.10.2009, at 15:19, Aleksey Samsonov wrote: > >> Hello, >> Martin, could you explain please what for we need this change? >> http://www.opensc-project.org/opensc/changeset/3752/branches/martin/0.12/src/libopensc/apdu.c >> >> >> if SC_APDU_CASE_3_SHORT and a

Re: [opensc-devel] Changeset 3752: sc_check_apdu and datalen (lc)

2009-10-03 Thread Martin Paljak
Either way it deserves a clear and longer than one line comment in the code, weather it allows 0 Lc or forbids it. m. On 03.10.2009, at 15:19, Aleksey Samsonov wrote: > Hello, > Martin, could you explain please what for we need this change? > http://www.opensc-project.org/opensc/changeset/3752/

Re: [opensc-devel] Changeset 3752: sc_check_apdu and datalen (lc)

2009-10-03 Thread Martin Paljak
On 03.10.2009, at 15:19, Aleksey Samsonov wrote: > Hello, > Martin, could you explain please what for we need this change? > http://www.opensc-project.org/opensc/changeset/3752/branches/martin/0.12/src/libopensc/apdu.c > if SC_APDU_CASE_3_SHORT and apdu->datalen == 0 and > apdu->lc == 0 then no e

[opensc-devel] Changeset 3752: sc_check_apdu and datalen (lc)

2009-10-03 Thread Aleksey Samsonov
Hello, Martin, could you explain please what for we need this change? http://www.opensc-project.org/opensc/changeset/3752/branches/martin/0.12/src/libopensc/apdu.c if SC_APDU_CASE_3_SHORT and apdu->datalen == 0 and apdu->lc == 0 then no error? Why? Thanks __