Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-07-12 Thread Thomas Grenman
Hi The attached patch works! Is this now something you could agree to commit to upcoming versions of OpenSC? And I will try to find someone at VRK who could tell me why the returned SW is violating the specifications for the SELECT command. br, Thomas On Tue, 12 Jul 2011, Martin Paljak wrote:

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-07-12 Thread Martin Paljak
Hello, On Jul 11, 2011, at 10:53 , Thomas Grenman wrote: > > I emailed the patch to Martin and CC to the list. The email never got > through to the list tough. Do not know why... You sent the e-mail from an address which was not subscribed and where messages bounced back from (like the notifica

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-07-12 Thread Martin Paljak
Hello, On Jul 11, 2011, at 14:46 , Viktor Tarasov wrote: > Hello, > > Le 11/07/2011 09:53, Thomas Grenman a écrit : >> One additional solution would be to patch the card specific select_file() > > Probably it would be the best solution . Attached is a version of the setcos specific select file

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-07-11 Thread Viktor Tarasov
Hello, Le 11/07/2011 09:53, Thomas Grenman a écrit : > One additional solution would be to patch the card specific select_file() Probably it would be the best solution . Kind regards, Viktor. ___ opensc-devel mailing list opensc-devel@lists.opensc-p

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-07-11 Thread Thomas Grenman
Hi! > As for me, > the cheap and close to the actual logic would be, inside the sc_enum_apps, > replace any error of selection of 2F00 by the SC_ERROR_FILE_NOT_FOUND. > Something like this: Patching dir.c alone is not enough. The same error (-1216) will come back at the next stage when pkcs15-

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-07-09 Thread Viktor Tarasov
Hello, Le 08/07/2011 08:56, Martin Paljak a écrit : > Viktor, any comments? As for me the 'most rigorous' solution would be the one proposed by Juan Antonio -- card specific SW checking. Checking for error SC_ERROR_FILE_NOT_FOUND and it's special treatment are frequently used in OpenSC, especia

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-07-07 Thread Martin Paljak
Hello, Viktor, any comments? Does the change make sense ? On Jul 7, 2011, at 09:01 , Thomas Grenman wrote: > Hi > > I just tested [2] and it works. Thanks! > > - Thomas > > On Wed, 6 Jul 2011, Martin Paljak wrote: > >> Hello, >> >> >> Here's an alternative approach [1]: requiring that sc_s

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-07-06 Thread Thomas Grenman
Hi I just tested [2] and it works. Thanks! - Thomas On Wed, 6 Jul 2011, Martin Paljak wrote: > Hello, > > > Here's an alternative approach [1]: requiring that sc_select_file > invocations would explicitly be successful for continuing. > > Does this work for you? To be honest the binding procedu

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-07-06 Thread Martin Paljak
Hello, Here's an alternative approach [1]: requiring that sc_select_file invocations would explicitly be successful for continuing. Does this work for you? To be honest the binding procedure could be improved further, it is somewhat difficult to follow. Look for builds with commit ID 9bcda91808

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my?? FINEID-card work

2011-07-06 Thread Martin Paljak
Hello, On Thu, Jun 30, 2011 at 22:13, Frank Morgner wrote: > Hi! > >> sc_enum_apps fails because sc_select_file returns an "unknown" SW 6A88 >> which gets translated to SC_ERROR_DATA_OBJECT_NOT_FOUND in iso7816.c. >> Looking at ISO7816-4, it is not listed as a "relevant SW" for SELECT >> command

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my?? FINEID-card work

2011-06-30 Thread Juan Antonio Martinez
El jue, 30-06-2011 a las 20:58 +0200, Frank Morgner escribió: > On Thursday, June 30 at 07:08PM, Juan Antonio Martinez wrote: > > In OpenDNIe[1] we had a similar problem: on SM establishment we need to > > override default meaning of some error codes, to get a common SM error > > and parse it. I so

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my?? FINEID-card work

2011-06-30 Thread Frank Morgner
Hi! > sc_enum_apps fails because sc_select_file returns an "unknown" SW 6A88 > which gets translated to SC_ERROR_DATA_OBJECT_NOT_FOUND in iso7816.c. > Looking at ISO7816-4, it is not listed as a "relevant SW" for SELECT > command, which is failing (which also makes sense to me) Regarding the erro

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my?? FINEID-card work

2011-06-30 Thread Frank Morgner
On Thursday, June 30 at 07:08PM, Juan Antonio Martinez wrote: > In OpenDNIe[1] we had a similar problem: on SM establishment we need to > override default meaning of some error codes, to get a common SM error > and parse it. I solved it by mean of providing own check_sw() at > card_ops function poi

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-06-30 Thread Juan Antonio Martinez
El jue, 30-06-2011 a las 19:58 +0300, Thomas Grenman escribió: > Hi > > > It seems to me that the card (or the relevant applet) is programmed to > > return 6A88 instead of 6A82. Just to be sure: what happens if you try > > opensc-explorer and try to cd to any non-existent DF with debug on, > > Ye

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-06-30 Thread Thomas Grenman
Hi > It seems to me that the card (or the relevant applet) is programmed to > return 6A88 instead of 6A82. Just to be sure: what happens if you try > opensc-explorer and try to cd to any non-existent DF with debug on, Yes, the error code comes from the card. And just as you expected, opensc-expl

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-06-30 Thread Martin Paljak
Hello, So this is the interesting part from the log: On Thu, Jun 30, 2011 at 17:21, Thomas Grenman wrote: > 0xb779b8d0 16:59:59.149 [pkcs15-tool] dir.c:141:sc_enum_apps: called > 0xb779b8d0 16:59:59.149 [pkcs15-tool] card.c:571:sc_select_file: called; > type=2, path=3f002f00 > 0xb779b8d0 16:59:5

Re: [opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-06-30 Thread Martin Paljak
Moi, On Thu, Jun 30, 2011 at 08:11, Thomas Grenman wrote: > Hello > > Please consider including the patch below into upcoming versions of > OpenSC. This patch will make OpenSC work with my fairly new FINEID-card > (http://www.opensc-project.org/opensc/wiki/FinnishEid). My particular card > is not

[opensc-devel] Patch for OpenSC (0.12.1) that will make my FINEID-card work

2011-06-29 Thread Thomas Grenman
Hello Please consider including the patch below into upcoming versions of OpenSC. This patch will make OpenSC work with my fairly new FINEID-card (http://www.opensc-project.org/opensc/wiki/FinnishEid). My particular card is not for private citizens but for organisations. I have only modified 'l