Re: [opensc-devel] Small minidriver fixes etc.

2011-12-09 Thread Viktor Tarasov
Le 09/12/2011 07:30, Hunter William a écrit : > On 08 December 2011 00:41 Douglas E. Engert wrote: >> With regards to the original problem of a short serial number >> being the issue, the problem may be that some code is comparing >> the MAX_CONTAINER_NAME_LEN as binary and not as a string. >> We m

Re: [opensc-devel] Small minidriver fixes etc.

2011-12-08 Thread Hunter William
On 08 December 2011 00:41 Douglas E. Engert wrote: > With regards to the original problem of a short serial number > being the issue, the problem may be that some code is comparing > the MAX_CONTAINER_NAME_LEN as binary and not as a string. > We may have in OpenSC some field that is not initialized

Re: [opensc-devel] Small minidriver fixes etc.

2011-12-08 Thread Douglas E. Engert
On 12/7/2011 6:04 AM, Hunter William wrote: >> -Original Message- >> From: Viktor Tarasov [mailto:viktor.tara...@gmail.com] >> >> Le 06/12/2011 16:42, Douglas E. Engert a écrit : >>> There are some cards where there is a GUID on the card card driver >>> can provide a routine to get the GU

Re: [opensc-devel] Small minidriver fixes etc.

2011-12-08 Thread Hunter William
> -Original Message- > From: Douglas E. Engert [mailto:deeng...@anl.gov] > Sent: 08 December 2011 00:41 > > > I did notice this - however, I also noticed that the piv_get_guid > routine returns values which > > are in a different format to the normal routine - it returns e.g. > "1A2B3C.

Re: [opensc-devel] Small minidriver fixes etc.

2011-12-08 Thread Douglas E. Engert
With regards to the original problem of a short serial number being the issue, the problem may be that some code is comparing the MAX_CONTAINER_NAME_LEN as binary and not as a string. We may have in OpenSC some field that is not initialized to null, foe example the WCHAR wszGuid [MAX_CONTAINER_NAME

Re: [opensc-devel] Small minidriver fixes etc.

2011-12-07 Thread Hunter William
> -Original Message- > From: Viktor Tarasov [mailto:viktor.tara...@gmail.com] > > Le 06/12/2011 16:42, Douglas E. Engert a écrit : > > There are some cards where there is a GUID on the card card driver > > can provide a routine to get the GUID. in card-piv.c: > >p15card->ops.get_guid =

Re: [opensc-devel] Small minidriver fixes etc.

2011-12-07 Thread Viktor Tarasov
Le 06/12/2011 16:42, Douglas E. Engert a écrit : > On 12/6/2011 1:04 AM, Hunter William wrote: >>> Since the minidriver is being built within the Microsoft Crypto >>> framework, rather then using OpenSSL SHA1, we could use a Microsoft hash >>> function. >>> >>> Thus we do not depend on #ifdef EN

Re: [opensc-devel] Small minidriver fixes etc.

2011-12-06 Thread Douglas E. Engert
On 12/6/2011 1:04 AM, Hunter William wrote: >> Since the minidriver is being built within the Microsoft Crypto >> framework, rather then using OpenSSL SHA1, we could use a Microsoft >> hash >> function. >> >> Thus we do not depend on #ifdef ENABLE_OPENSSL for this one purpose. >> > > Ok, this is

Re: [opensc-devel] Small minidriver fixes etc.

2011-12-05 Thread Hunter William
> Since the minidriver is being built within the Microsoft Crypto > framework, rather then using OpenSSL SHA1, we could use a Microsoft > hash > function. > > Thus we do not depend on #ifdef ENABLE_OPENSSL for this one purpose. > Ok, this is a good idea. I can make this change. One question tho

Re: [opensc-devel] Small minidriver fixes etc.

2011-12-05 Thread Douglas E. Engert
On 12/4/2011 11:00 AM, Viktor Tarasov wrote: > Hello, > > Le 02/12/2011 16:46, Hunter William a écrit : >> I've attached a patch for some updates that I've made to Viktor's >> secure-messaging branch. Sorry about the size and number of changes - I >> didn't initially think that there would be s

Re: [opensc-devel] Small minidriver fixes etc.

2011-12-04 Thread Viktor Tarasov
Hello, Le 02/12/2011 16:46, Hunter William a écrit : > I've attached a patch for some updates that I've made to Viktor's > secure-messaging branch. Sorry about the size and number of changes - I > didn't initially think that there would be so many. The commit details are > after this message. I

Re: [opensc-devel] Small minidriver fixes etc.

2011-12-02 Thread Viktor Tarasov
Hello William, Thanks, I will consider you proposals this weekend. Rapidly I would like to note that: I have an intention to change the format of the on-card MD help files (like for 'cmapfile'), to make it similar to the format that Gemalto is using. My intention is to not create/write them in M

[opensc-devel] Small minidriver fixes etc.

2011-12-02 Thread Hunter William
Hi, I've attached a patch for some updates that I've made to Viktor's secure-messaging branch. Sorry about the size and number of changes - I didn't initially think that there would be so many. The commit details are after this message. I've used the secure-messaging branch because it seems to