Re: [opensc-devel] bugs in suse bugzilla

2009-03-05 Thread Andreas Jellinghaus
hmm, right. I thought "end" pointed to the last byte of the string passed. but looking closer I see: end = p + len; so we are not allowed to look at *end, as we could segfault with that. I think this is misleading. the end if your car is part of your car, not some space behind it.

Re: [opensc-devel] bugs in suse bugzilla

2009-03-05 Thread Stanislav Brabec
Andreas Jellinghaus wrote in Thu 03/05 2009 at 17:18 +0100: > if they had a problem with the old if clause, why doesn't the > same compiler/checker complain about the while clause that > copies the *p++ into the tag? No problem for compiler: while (p < end && (tag = *p++) != 0 && tag != 0xFF) No

Re: [opensc-devel] bugs in suse bugzilla

2009-03-05 Thread Douglas E. Engert
Andreas Jellinghaus wrote: > Am Donnerstag 05 März 2009 16:54:49 schrieb Douglas E. Engert: >> Andreas Jellinghaus wrote: >>> Am Donnerstag 05 März 2009 16:18:53 schrieb Andreas Jellinghaus: suse found a number of maybe issue. I think most are not, and added comments in their bugzilla.

Re: [opensc-devel] bugs in suse bugzilla

2009-03-05 Thread Andreas Jellinghaus
Am Donnerstag 05 März 2009 16:54:49 schrieb Douglas E. Engert: > Andreas Jellinghaus wrote: > > Am Donnerstag 05 März 2009 16:18:53 schrieb Andreas Jellinghaus: > >> suse found a number of maybe issue. > >> I think most are not, and added comments in their bugzilla. > >> > >> still could some of yo

Re: [opensc-devel] bugs in suse bugzilla

2009-03-05 Thread Douglas E. Engert
Andreas Jellinghaus wrote: > Am Donnerstag 05 März 2009 16:18:53 schrieb Andreas Jellinghaus: >> suse found a number of maybe issue. >> I think most are not, and added comments in their bugzilla. >> >> still could some of you have a look and tell me if I was right or wrong? >> >> https://bugzilla

Re: [opensc-devel] bugs in suse bugzilla

2009-03-05 Thread Douglas E. Engert
Andreas Jellinghaus wrote: > suse found a number of maybe issue. > I think most are not, and added comments in their bugzilla. > > still could some of you have a look and tell me if I was right or wrong? > > https://bugzilla.novell.com/show_bug.cgi?id=480262 > (our SA, gpk and rutoken changes,

Re: [opensc-devel] bugs in suse bugzilla

2009-03-05 Thread Andreas Jellinghaus
Am Donnerstag 05 März 2009 16:18:53 schrieb Andreas Jellinghaus: > suse found a number of maybe issue. > I think most are not, and added comments in their bugzilla. > > still could some of you have a look and tell me if I was right or wrong? > > https://bugzilla.novell.com/show_bug.cgi?id=480262 >

[opensc-devel] bugs in suse bugzilla

2009-03-05 Thread Andreas Jellinghaus
suse found a number of maybe issue. I think most are not, and added comments in their bugzilla. still could some of you have a look and tell me if I was right or wrong? https://bugzilla.novell.com/show_bug.cgi?id=480262 (our SA, gpk and rutoken changes, micos, setcos, oberthur cards, pkcs15 prof