Re: updated spec for DTrace TCP and UDP providers [PSARC/2010/106]

2010-05-05 Thread Alan Maguire
On 05/05/2010 03:00, Darren Reed wrote: On 2/05/10 02:32 AM, Alan Maguire wrote: As per the subject line, the updated spec is attached for the above fasttrack. In the interim, the project team have worked offline with Kacheong and Darren to address their concerns. We have also incorporated

Re: updated spec for DTrace TCP and UDP providers [PSARC/2010/106]

2010-05-04 Thread Nicolas Williams
On Sun, May 02, 2010 at 10:32:27AM +0100, Alan Maguire wrote: tcp:::send TCP transmits a segment. tcp:::receive TCP receives a segment. I don't see probes for sending/receiving ACKs; I assume these two fire even for packets that have no data. I also don't see a probe for a

Re: updated spec for DTrace TCP and UDP providers [PSARC/2010/106]

2010-05-04 Thread Nicolas Williams
It's probably too late for this case, but if so, then something to keep in mind for a future case: IPsec latching (see ipsec_latch_t, in $SRC/uts/common/inet/ip.h). This could either be subsumed into ipinfo_t or, better, added as one more probe argument, both on receive and on send probes. IPsec

Re: updated spec for DTrace TCP and UDP providers [PSARC/2010/106]

2010-05-04 Thread Nicolas Williams
On Tue, May 04, 2010 at 07:16:22PM +0100, Alan Maguire wrote: On 04/05/2010 18:36, Nicolas Williams wrote: On Sun, May 02, 2010 at 10:32:27AM +0100, Alan Maguire wrote: tcp:::send TCP transmits a segment. tcp:::receive TCP receives a segment. I don't see probes for

Re: updated spec for DTrace TCP and UDP providers [PSARC/2010/106]

2010-05-04 Thread Alan Maguire
On 04/05/2010 18:36, Nicolas Williams wrote: On Sun, May 02, 2010 at 10:32:27AM +0100, Alan Maguire wrote: tcp:::send TCP transmits a segment. tcp:::receive TCP receives a segment. I don't see probes for sending/receiving ACKs; I assume these two fire even for

Re: updated spec for DTrace TCP and UDP providers [PSARC/2010/106]

2010-05-04 Thread Darren Reed
On 2/05/10 02:32 AM, Alan Maguire wrote: As per the subject line, the updated spec is attached for the above fasttrack. In the interim, the project team have worked offline with Kacheong and Darren to address their concerns. We have also incorporated SACK, PMTU and congestion window info into