Re: [opensource-dev] Review Request: STORM-1118 Viewer crashes when user tries to upload image without JFIF header

2011-04-15 Thread Kiptic Horsley
> On April 8, 2011, 4:51 p.m., Boroondas Gupte wrote: > > indra/llimage/llimagedimensionsinfo.cpp, lines 217-219 > > > > > > Wouldn't a seek be a "cheaper" way to determine size than reading into > > an actual buffer?

[opensource-dev] Widespread, Reproducible Profile Total Data Loss - Tolerated for multiple releases, why?

2011-04-15 Thread Arrehn Oberlander
The subject says it all. If you were not aware, editing profile data using the web profile interface can result in whatever section of data that you edited being completely erased, wiped out, 8-24hrs later. This issue was first reported back in 2.5.0. I was bit by it myself. I updated my "Real Wor

Re: [opensource-dev] Widespread, Reproducible Profile Total Data Loss - Tolerated for multiple releases, why?

2011-04-15 Thread Boroondas Gupte
On 04/15/2011 03:11 PM, Arrehn Oberlander wrote: > [...] editing profile data using the web profile interface can result > in whatever section of data that you edited being completely erased, > wiped out, 8-24hrs later. [...] > Apparently this is a widely known problem. When I started asking > arou

Re: [opensource-dev] Widespread, Reproducible Profile Total Data Loss - Tolerated for multiple releases, why?

2011-04-15 Thread Oz Linden (Scott Lawrence)
On 2011-04-15 9:11, Arrehn Oberlander wrote: > The subject says it all. If you were not aware, editing profile data > using the web profile interface can result in whatever section of data > that you edited being completely erased, wiped out, 8-24hrs later. > > This issue was first reported back

Re: [opensource-dev] Review Request: STORM-1118 Viewer crashes when user tries to upload image without JFIF header

2011-04-15 Thread Vadim ProductEngine
> On April 8, 2011, 4:51 p.m., Boroondas Gupte wrote: > > indra/llimage/llimagedimensionsinfo.cpp, lines 217-219 > > > > > > Wouldn't a seek be a "cheaper" way to determine size than reading into > > an actual buffer?

Re: [opensource-dev] Windows compiling problem

2011-04-15 Thread Monty Brandenberg
On 4/14/2011 8:37 PM, Jonathan Welch wrote: > Knowing what I had to do to fix this problem now tells me that when I > had to restore my C drive from a backup the backup was not quite > up-to-date and a few things I had changed since it had been made had > to be reapplied. Well, extra credit for h

Re: [opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

2011-04-15 Thread Twisted Laws
> On April 14, 2011, 1:01 p.m., Vadim ProductEngine wrote: > > indra/newview/skins/default/xui/en/menu_people_nearby_view_sort.xml, line 45 > > > > > > I'd say "View Mini-Map": by "Map" we usually mean the world map, wh

Re: [opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

2011-04-15 Thread Vadim ProductEngine
> On April 14, 2011, 1:01 p.m., Vadim ProductEngine wrote: > > indra/newview/skins/default/xui/en/menu_people_nearby_view_sort.xml, line 45 > > > > > > I'd say "View Mini-Map": by "Map" we usually mean the world map, wh

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

2011-04-15 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/ --- (Updated April 15, 2011, 11:33 a.m.) Review request for Viewer. Changes -

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

2011-04-15 Thread Jonathan Yap
> On April 13, 2011, 1:26 p.m., Vadim ProductEngine wrote: > > indra/newview/llfloaterworldmap.cpp, line 1497 > > > > > > CS: sim_info_vec Changed. > On April 13, 2011, 1:26 p.m., Vadim ProductEngine wrote: > > ind

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

2011-04-15 Thread Jonathan Yap
> On April 13, 2011, 2:31 p.m., Boroondas Gupte wrote: > > indra/newview/llfloaterworldmap.cpp, lines 99-101 > > > > > > Why do you make this a functor rather than a plain normal function? > > It's not like we have to

Re: [opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

2011-04-15 Thread Twisted Laws
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/265/ --- (Updated April 15, 2011, 11:46 a.m.) Review request for Viewer. Changes -

Re: [opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

2011-04-15 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/265/#review621 --- Ship it! indra/newview/skins/default/xui/en/panel_people.xml

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

2011-04-15 Thread Boroondas Gupte
> On April 13, 2011, 2:31 p.m., Boroondas Gupte wrote: > > indra/newview/llfloaterworldmap.cpp, lines 99-101 > > > > > > Why do you make this a functor rather than a plain normal function? > > It's not like we have to

[opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network

2011-04-15 Thread Ima Mechanique
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/271/ --- Review request for Viewer. Summary --- Applying Kitty Barnett's patch

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

2011-04-15 Thread Jonathan Yap
> On April 13, 2011, 2:31 p.m., Boroondas Gupte wrote: > > indra/newview/llfloaterworldmap.cpp, lines 99-101 > > > > > > Why do you make this a functor rather than a plain normal function? > > It's not like we have to

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

2011-04-15 Thread Boroondas Gupte
> On April 13, 2011, 2:31 p.m., Boroondas Gupte wrote: > > indra/newview/llfloaterworldmap.cpp, lines 99-101 > > > > > > Why do you make this a functor rather than a plain normal function? > > It's not like we have to

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

2011-04-15 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/#review626 --- I tried to compile with your change on Linux (g++ 4.4.5) indra/n