[opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-28 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/127/ --- Review request for Viewer. Summary --- During initialization, if there

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-28 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/127/#review263 --- Ship it! Looks plausible at first sight. - Vadim On Jan. 28, 2

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-28 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/127/#review265 --- autobuild/common.py

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-28 Thread Wolfpup Lowenhar
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/127/#review266 --- Ship it! Tested on Windows 7 32-bit and works all the needed file

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-28 Thread Oz Linden
> On Jan. 28, 2011, 5:51 a.m., Jonathan Yap wrote: > > autobuild/common.py, line 106 > > > > > > Why send out a warning at this point? Developers who will never use > > scp don't benefit from this message. If scp is n

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-28 Thread Nicky Perian
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/127/#review271 --- Ship it! Worked as designed/explained. For other dummies like me

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-28 Thread Alain Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/127/#review274 --- autobuild/common.py

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-29 Thread Boroondas Gupte
> On Jan. 28, 2011, 2:46 p.m., Alain Linden wrote: > > autobuild/common.py, line 415 > > > > > > ...and test for None here. Good idea. This would avoid bugs that could occur e.g. when the string is changed and not spel

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-29 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/127/ --- (Updated Jan. 29, 2011, 5:01 a.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-29 Thread Wolfpup Lowenhar
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/127/#review278 --- this is crashing devenv when you do autobuild build -c OpenSourceR

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-29 Thread Wolfpup Lowenhar
> On Jan. 29, 2011, 7:28 a.m., Wolfpup Lowenhar wrote: > > this is crashing devenv when you do autobuild build -c > > OpenSourceRelWithDebInfo on a windows system When i tested this second dif was not a clean reop will retest again after deleating build tree - Wolfpup

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-29 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/127/#review280 --- autobuild/common.py

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-30 Thread Wolfpup Lowenhar
> On Jan. 29, 2011, 7:28 a.m., Wolfpup Lowenhar wrote: > > this is crashing devenv when you do autobuild build -c > > OpenSourceRelWithDebInfo on a windows system > > Wolfpup Lowenhar wrote: > When i tested this second dif was not a clean reop will retest again > after deleating build tre

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-02-01 Thread Nicky Perian
the file ogg-vorbis-1.1.3-1.2.0-windows-20101001a.tar.bz2 is in autobuild.xml and is in the install.cache. and does download manually From: Nicky Perian To: Nicky Perian ; Oz Linden ; Viewer Sent: Fri, January 28, 2011 12:34:52 PM Subject: Re: Review R