Re: [opensource-dev] Review Request: Enable CURLOPT_ENCODING for Inventory caps, which uses the LLURLRequest code path

2011-03-31 Thread Joshua Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/242/#review529 --- Ship it! Looks good. Empty-string ("") is a signal to curl to s

Re: [opensource-dev] Review Request: Enable CURLOPT_ENCODING for Inventory caps, which uses the LLURLRequest code path

2011-03-31 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/242/ --- (Updated March 31, 2011, 7:32 a.m.) Review request for Viewer, Oz Linden, J

Re: [opensource-dev] Review Request: Enable CURLOPT_ENCODING for Inventory caps, which uses the LLURLRequest code path

2011-03-30 Thread Stone Linden
> On March 29, 2011, 6:02 p.m., Merov Linden wrote: > > Looks good. > > Merov Linden wrote: > BTW, what's the JIRA for this patch? > > Stone Linden wrote: > VWR-25286 Sorry, VWR-25376 - Stone --- This is an automatically gener

Re: [opensource-dev] Review Request: Enable CURLOPT_ENCODING for Inventory caps, which uses the LLURLRequest code path

2011-03-30 Thread Stone Linden
> On March 29, 2011, 6:02 p.m., Merov Linden wrote: > > Looks good. > > Merov Linden wrote: > BTW, what's the JIRA for this patch? VWR-25286 - Stone --- This is an automatically generated e-mail. To reply, visit: http://codereview.

Re: [opensource-dev] Review Request: Enable CURLOPT_ENCODING for Inventory caps, which uses the LLURLRequest code path

2011-03-29 Thread Merov Linden
> On March 29, 2011, 6:02 p.m., Merov Linden wrote: > > Looks good. BTW, what's the JIRA for this patch? - Merov --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/242/#review521 -

Re: [opensource-dev] Review Request: Enable CURLOPT_ENCODING for Inventory caps, which uses the LLURLRequest code path

2011-03-29 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/242/#review521 --- Ship it! Looks good. - Merov On March 28, 2011, 6:22 p.m., Sto

Re: [opensource-dev] Review Request: Enable CURLOPT_ENCODING for Inventory caps, which uses the LLURLRequest code path

2011-03-29 Thread Stone Linden
> On March 28, 2011, 9:12 p.m., Monty Brandenberg wrote: > > Before shipping, review the exploit history around CURLOPT_ENCODING. There > > is a > > known buffer overflow exploit, I believe in pre-7.20 releases but that > > should be > > checked first for applicability. Thank you, found it: h

Re: [opensource-dev] Review Request: Enable CURLOPT_ENCODING for Inventory caps, which uses the LLURLRequest code path

2011-03-28 Thread Monty Brandenberg
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/242/#review512 --- Before shipping, review the exploit history around CURLOPT_ENCODIN

[opensource-dev] Review Request: Enable CURLOPT_ENCODING for Inventory caps, which uses the LLURLRequest code path

2011-03-28 Thread Stone Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/242/ --- Review request for Viewer, Oz Linden, Joshua Linden, and Brad Kittenbrink.