[opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/153/ --- Review request for Viewer. Summary --- https://jira.secondlife.com/bro

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/153/#review392 --- Ship it! indra/llcommon/llavatarname.cpp

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

> On Feb. 27, 2011, 5:57 a.m., Boroondas Gupte wrote: > > indra/llcommon/llavatarname.cpp, lines 93-108 > > > > > > This could be shortened to > > > > if (!mUsername.empty() && !mIsDisplayNameDefault) > >

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

> On Feb. 27, 2011, 5:57 a.m., Boroondas Gupte wrote: > > Works as advertised for me in use in world and I've not found any adverse effects. Aleric's rewriting (with comment) makes the most sense. - Twisted --- This is an automatical

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/153/ --- (Updated March 3, 2011, 9:25 p.m.) Review request for Viewer. Summary ---

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/153/#review418 --- Ship it! Aleric's right, this is even cleaner :-) indra/llcommo

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

> On Feb. 27, 2011, 5:57 a.m., Boroondas Gupte wrote: > > indra/llcommon/llavatarname.cpp, lines 93-108 > > > > > > This could be shortened to > > > > if (!mUsername.empty() && !mIsDisplayNameDefault) > >

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

> On March 4, 2011, 3:05 a.m., Boroondas Gupte wrote: > > indra/llcommon/llavatarname.cpp, lines 93-95 > > > > > > Nitpicking now, but it should be "i.e.", not "ie". Also, the defaulted > > display name is NOT the same

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/153/ --- (Updated March 4, 2011, 5:11 a.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/153/#review421 --- Ship it! - Oz On March 4, 2011, 5:11 a.m., ardy.lay wrote: > >

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/153/#review422 --- Ship it! Perfect :-) - Boroondas On March 4, 2011, 5:11 a.m.,