[opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/ --- Review request for Viewer. Summary --- Chat preferences > font size s

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/ --- (Updated March 30, 2011, 5:43 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review523 --- indra/llui/lllineeditor.h

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review539 --- Boroondas comments should be addressed, especially the one here un

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

> On March 30, 2011, 3:16 p.m., Boroondas Gupte wrote: > > indra/llui/lllineeditor.cpp, lines 2294-2297 > > > > > > ... this simple setter isn't implemented right at the declaration (i.e. > > in indra/llui/lllineedit

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

> On April 3, 2011, 8:46 p.m., Merov Linden wrote: > > indra/newview/llviewerchat.cpp, lines 38-39 > > > > > > Should be initialized to NULL. I fixed that initialization to NULL issue and that change was in the last PO

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review556 --- indra/newview/llnearbychatbar.h

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

> On April 5, 2011, 12:35 p.m., Vadim ProductEngine wrote: > > indra/newview/llnearbychatbar.h, line 118 > > > > > > Remove the class prefix: it may cause compilation problems on Linux. Does cause failure on Linux...

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/ --- (Updated April 13, 2011, 6:40 a.m.) Review request for Viewer. Summary --

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review589 --- Ship it! Looks good. Some minor stuff still: indra/newview/llv

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

> On April 13, 2011, 7:19 a.m., Boroondas Gupte wrote: > > indra/newview/llviewerchat.h, lines 37-39 > > > > > > Why repeat the 'public:' ? Vadim's RB comments and other LL code implied this was the way to go. I've

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review591 --- Thanks, Jonathan. No major issues this time. I've got a few comme

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/ --- (Updated April 13, 2011, 12:32 p.m.) Review request for Viewer. Changes -

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

> On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote: > > indra/newview/llbottomtray.cpp, lines 560-561 > > > > > > Any reason not to move this to LLNearbyChatBar::postBuild() ? Yes, there is a reason, though no

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review596 --- Ship it! doc/contributions.txt

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

> On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote: > > indra/newview/llbottomtray.cpp, lines 560-561 > > > > > > Any reason not to move this to LLNearbyChatBar::postBuild() ? > > Jonathan Yap wrote: > Yes

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

> On April 13, 2011, 1:13 p.m., Vadim ProductEngine wrote: > > doc/contributions.txt, line 416 > > > > > > fix this before committing Fixed > On April 13, 2011, 1:13 p.m., Vadim ProductEngine wrote: > > doc/contribu

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

> On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote: > > indra/newview/llbottomtray.cpp, lines 560-561 > > > > > > Any reason not to move this to LLNearbyChatBar::postBuild() ? > > Jonathan Yap wrote: > Yes