[opensource-dev] Review Request: STORM-1118 Viewer crashes when user tries to upload image without JFIF header

2011-04-07 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/255/ --- Review request for Viewer. Summary --- * Added checks for image file c

Re: [opensource-dev] Review Request: STORM-1118 Viewer crashes when user tries to upload image without JFIF header

2011-04-08 Thread Seth ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/255/#review574 --- Ship it! Looks good to me. - Seth On April 7, 2011, 4:20 p.m.,

Re: [opensource-dev] Review Request: STORM-1118 Viewer crashes when user tries to upload image without JFIF header

2011-04-08 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/255/#review580 --- indra/llimage/llimagedimensionsinfo.h

Re: [opensource-dev] Review Request: STORM-1118 Viewer crashes when user tries to upload image without JFIF header

2011-04-11 Thread Vadim ProductEngine
> On April 8, 2011, 4:51 p.m., Boroondas Gupte wrote: > > indra/llimage/llimagedimensionsinfo.cpp, line 97 > > > > > > Magic number. (I guess it's BMP header (14) + DIB header - current > > position (File begin + 2)?)

Re: [opensource-dev] Review Request: STORM-1118 Viewer crashes when user tries to upload image without JFIF header

2011-04-11 Thread Boroondas Gupte
> On April 8, 2011, 4:51 p.m., Boroondas Gupte wrote: > > indra/llimage/llimagedimensionsinfo.cpp, line 147 > > > > > > ... until here. (Assuming it's the same 8.) Might be worth another > > constant. > > Vadim Produ

Re: [opensource-dev] Review Request: STORM-1118 Viewer crashes when user tries to upload image without JFIF header

2011-04-11 Thread Tateru Nino
On 12/04/2011 9:31 AM, Vadim ProductEngine wrote: > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/255/ > > > On April 8th, 2011, 4:51 p.m., *Boroondas Gupte* wrote: > > indra/llimage/llimagedimensionsinfo.cpp > >

Re: [opensource-dev] Review Request: STORM-1118 Viewer crashes when user tries to upload image without JFIF header

2011-04-12 Thread Vadim ProductEngine
> On April 8, 2011, 4:51 p.m., Boroondas Gupte wrote: > > indra/llimage/llimagedimensionsinfo.cpp, line 97 > > > > > > Magic number. (I guess it's BMP header (14) + DIB header - current > > position (File begin + 2)?)

Re: [opensource-dev] Review Request: STORM-1118 Viewer crashes when user tries to upload image without JFIF header

2011-04-15 Thread Kiptic Horsley
> On April 8, 2011, 4:51 p.m., Boroondas Gupte wrote: > > indra/llimage/llimagedimensionsinfo.cpp, lines 217-219 > > > > > > Wouldn't a seek be a "cheaper" way to determine size than reading into > > an actual buffer?

Re: [opensource-dev] Review Request: STORM-1118 Viewer crashes when user tries to upload image without JFIF header

2011-04-15 Thread Vadim ProductEngine
> On April 8, 2011, 4:51 p.m., Boroondas Gupte wrote: > > indra/llimage/llimagedimensionsinfo.cpp, lines 217-219 > > > > > > Wouldn't a seek be a "cheaper" way to determine size than reading into > > an actual buffer?