[opensource-dev] Review Request: STORM-1427 Crash in world map when region name search is empty (Assert fails in LLWorldMapMessage::processMapBlockReply)

2011-08-05 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/432/ --- Review request for Viewer. Summary --- Fixed a debug assertion trigger

Re: [opensource-dev] Review Request: STORM-1427 Crash in world map when region name search is empty (Assert fails in LLWorldMapMessage::processMapBlockReply)

2011-08-05 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/432/#review953 --- Thanks for looking into this. I've stopped counting how often I've

Re: [opensource-dev] Review Request: STORM-1427 Crash in world map when region name search is empty (Assert fails in LLWorldMapMessage::processMapBlockReply)

2011-08-07 Thread Vadim ProductEngine
> On Aug. 5, 2011, 2:07 p.m., Boroondas Gupte wrote: > > Thanks for looking into this. I've stopped counting how often I've crashed > > due to this. > > > > > Apparently, passing empty region name to the MapNameRequest makes server > > > return > > > empty name in MapBlockReply, which triggere

Re: [opensource-dev] Review Request: STORM-1427 Crash in world map when region name search is empty (Assert fails in LLWorldMapMessage::processMapBlockReply)

2011-08-08 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/432/#review957 --- Ship it! I don't agree with your early return rationale, but let'

Re: [opensource-dev] Review Request: STORM-1427 Crash in world map when region name search is empty (Assert fails in LLWorldMapMessage::processMapBlockReply)

2011-08-08 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/432/#review959 --- Ship it! > The assert will not be in issue for release builds. >

Re: [opensource-dev] Review Request: STORM-1427 Crash in world map when region name search is empty (Assert fails in LLWorldMapMessage::processMapBlockReply)

2011-08-08 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/432/ --- (Updated Aug. 8, 2011, 10:51 a.m.) Review request for Viewer. Changes ---